From: Augustin Vidovic <vido@ldh.org>
To: linux-kernel@vger.kernel.org
Cc: torvalds@transmeta.com, alan@redhat.com
Subject: [PATCH] eepro100.c, kernel 2.4.1
Date: Thu, 8 Feb 2001 14:53:55 +0900 [thread overview]
Message-ID: <20010208145355.A18627@ldh.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 1657 bytes --]
Patch for drivers/net/eepro100.c in kernel 2.4.1 (and before).
For some of the bugged Intel EtherExpress Pro 100 network cards,
although the driver diagnoses the receiver lock-up bug, the workaround
is not enabled. It appears that the test for the diagnostic and the test
for the workaround activation are different. I assumed the diagnostic
test is OK and I changed the work-around activation test. I had several
Intel ISP1100 boxes with the bug diagnosed, but the workaround not enabled,
and after the patch, the workaround is activated and the boxes seem to
be alright even under very high network trafic (they were failing before,
due to the card bug, I think).
Attached is the tarball of the patch, I believe conform to the list
FAQ guidelines. Since the patch is only one line, I also include it
in the body of this message as plain text.
--- linux-2.4.1/drivers/net/eepro100.c Sun Jan 28 03:40:14 2001
+++ linux-2.4.1-vido1/drivers/net/eepro100.c Thu Feb 8 14:08:49 2001
@@ -815,7 +815,7 @@
sp->phy[0] = eeprom[6];
sp->phy[1] = eeprom[7];
- sp->rx_bug = (eeprom[3] & 0x03) == 3 ? 0 : 1;
+ sp->rx_bug = eeprom[3] & 0x03;
if (sp->rx_bug)
printk(KERN_INFO " Receiver lock-up workaround activated.\n");
I don't understand why the tests for the diagnostic and for the
workaround activation were different. Maybe a simple bug, but maybe there
was an obscure reason. I someone knows...
--
Augustin Vidovic http://www.vidovic.org/augustin/
"Nous sommes tous quelque chose de naissance, musicien ou assassin,
mais il faut apprendre le maniement de la harpe ou du couteau."
[-- Attachment #2: patch-eepro100-vido1.tar --]
[-- Type: application/x-tar, Size: 10240 bytes --]
next reply other threads:[~2001-02-08 5:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-08 5:53 Augustin Vidovic [this message]
2001-02-08 7:23 ` [PATCH] eepro100.c, kernel 2.4.1 Ion Badulescu
2001-02-08 7:37 ` Augustin Vidovic
2001-02-08 7:42 ` Alan Cox
2001-02-08 7:55 ` Andrey Savochkin
2001-02-08 7:59 ` [PATCH] " Ion Badulescu
2001-02-08 10:41 ` Augustin Vidovic
2001-02-08 11:00 ` Ion Badulescu
2001-02-08 11:15 ` Augustin Vidovic
2001-02-08 11:26 ` Ion Badulescu
2001-02-08 11:44 ` Augustin Vidovic
2001-02-08 11:53 ` Ion Badulescu
2001-02-08 12:08 ` Augustin Vidovic
2001-02-12 5:32 ` Andrey Savochkin
2001-02-12 9:00 ` Ion Badulescu
2001-02-20 6:30 ` Augustin Vidovic
2001-02-20 7:21 ` Andrey Savochkin
2001-02-20 8:18 ` Augustin Vidovic
2001-02-20 23:38 ` Andrey Savochkin
-- strict thread matches above, loose matches on Subject: below --
2001-02-09 14:38 [PATCH] " Peter Lund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010208145355.A18627@ldh.org \
--to=vido@ldh.org \
--cc=alan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox