public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
To: Thomas Hood <jdthoodREMOVETHIS@yahoo.co.uk>
Cc: linux-kernel@vger.kernel.org, jschlst@turbolinux.com,
	Andrew Morton <andrewm@uow.edu.au>,
	"Bryan K. Walton" <bryan@bryansweb.com>,
	Russell Coker <russell@coker.com.au>,
	dahinds@sourceforge.net, kuznet@ms2.inr.ac.ru,
	jgarzik@mandrakesoft.com
Subject: Re: [PATCH] to deal with bad dev->refcnt in unregister_netdevice()
Date: Mon, 12 Feb 2001 15:27:07 -0200	[thread overview]
Message-ID: <20010212152707.B31354@conectiva.com.br> (raw)
In-Reply-To: <3A8831D2.7EDB25D3@yahoo.co.uk>
In-Reply-To: <3A8831D2.7EDB25D3@yahoo.co.uk>; from jdthoodREMOVETHIS@yahoo.co.uk on Mon, Feb 12, 2001 at 01:56:18PM -0500

Em Mon, Feb 12, 2001 at 01:56:18PM -0500, Thomas Hood escreveu:
> Sorry, but it turns out that the bug is not completely
> fixed by the change that acme made.  With the change,
> ifup-ing and if-downing eth0 with the ipx module loaded
> no longer reduces eth0's refcnt to an indefinitely low
> (larger and larger negative) number.  However if the ipx
> module is loaded first and ipx configured on eth0, and
> then the network card inserted and "ifconfig eth0 up" done,
> and then "ifconfig eth0 down" done, then once again the
> refcnt is too low, so that when I try to "cardctl eject"
> my ethernet card, "modprobe -r xirc2ps_cs" hangs up.
> This whole business of refcnts needs to be thought 
> through more carefully.

As I've told in the message I've sent, I'm unfortunately damn busy these
days and wrote this patch in a hurry, was waiting for your feedback to see
if it fixed the problem or not, but it was applied because it seemed
obviously correct. I'll try to work on this as soon as possible, but this
can take some time.

- Arnaldo
 
> > This bug was fixed by "acme" in 2.4.1-ac10.  :)
> > The ipx driver now increments refcnt on NETDEV_UP to
> > match downing the interface on NETDEV_DOWN.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://vger.kernel.org/lkml/

  reply	other threads:[~2001-02-12 19:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-02-12 18:56 [PATCH] to deal with bad dev->refcnt in unregister_netdevice() Thomas Hood
2001-02-12 17:27 ` Arnaldo Carvalho de Melo [this message]
  -- strict thread matches above, loose matches on Subject: below --
2001-03-10  2:46 Thomas Hood
     [not found] <20010214092251.D1144@e-trend.de>
     [not found] ` <3A8AA725.7446DEA0@ubishops.ca>
     [not found]   ` <20010214165758.L28359@e-trend.de>
     [not found]     ` <20010214122244.H7859@conectiva.com.br>
2001-02-15 21:13       ` Thomas Hood
2001-02-21 16:22       ` Thomas Hood
2001-02-12 12:53 Thomas Hood
2001-02-10  6:01 Thomas Hood
2001-02-09  5:44 Thomas Hood
2001-02-08  0:46 Thomas Hood
2001-02-08 19:31 ` kuznet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010212152707.B31354@conectiva.com.br \
    --to=acme@conectiva.com.br \
    --cc=andrewm@uow.edu.au \
    --cc=bryan@bryansweb.com \
    --cc=dahinds@sourceforge.net \
    --cc=jdthoodREMOVETHIS@yahoo.co.uk \
    --cc=jgarzik@mandrakesoft.com \
    --cc=jschlst@turbolinux.com \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=russell@coker.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox