From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
To: Jeff Garzik <jgarzik@mandrakesoft.mandrakesoft.com>
Cc: Manfred Spraul <manfred@colorfullife.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] network driver updates
Date: Wed, 14 Feb 2001 11:13:38 -0200 [thread overview]
Message-ID: <20010214111338.C7859@conectiva.com.br> (raw)
In-Reply-To: <3A8A7159.AF0E6180@colorfullife.com> <Pine.LNX.3.96.1010214055331.12910R-100000@mandrakesoft.mandrakesoft.com>
In-Reply-To: <Pine.LNX.3.96.1010214055331.12910R-100000@mandrakesoft.mandrakesoft.com>; from jgarzik@mandrakesoft.mandrakesoft.com on Wed, Feb 14, 2001 at 05:54:34AM -0600
Em Wed, Feb 14, 2001 at 05:54:34AM -0600, Jeff Garzik escreveu:
> On Wed, 14 Feb 2001, Manfred Spraul wrote:
> > * dev->mem_start: NULL means "not command line configuration" 0xffffffff
> > means "default".
> > several drivers only check for NULL, not for 0xffffffff.
>
> netdev->mem_start is unsigned long... Should the test be for ~0 instead?
> The value 0xFFFFFFFF seems wrong for 64-bit machines.
I've added this to the Janitor's TODO List.
http://bazar.conectiva.com.br/~acme/TODO
- Arnaldo
next prev parent reply other threads:[~2001-02-14 14:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.3.96.1010214020707.28011E-100000@mandrakesoft.mandrakesoft.com>
2001-02-14 11:51 ` [PATCH] network driver updates Manfred Spraul
2001-02-14 11:54 ` Jeff Garzik
2001-02-14 13:13 ` Arnaldo Carvalho de Melo [this message]
2001-02-14 12:00 ` Jeff Garzik
2001-02-14 13:33 ` Andrew Morton
2001-02-14 17:38 ` David Hinds
2001-02-14 17:54 ` Jeff Garzik
2001-02-14 17:56 ` Manfred Spraul
2001-02-15 11:49 ` Andrew Morton
2001-02-15 17:08 ` David Hinds
2001-02-15 22:16 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010214111338.C7859@conectiva.com.br \
--to=acme@conectiva.com.br \
--cc=jgarzik@mandrakesoft.mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox