Re: [PATCH] eepro100.c, kernel 2.4.1

Ion Badulescu
2001-02-08T11:27:21Z

On Thu, 8 Feb 2001 20:15:39 +0900, Augustin Vidovic <vido@ldh.org> wrote:

>> So what _were_ those messages? Can you post them?
>
> No I can't because they were suppressed by the syslogd (DOS protection), only
> their number being reported (several thousands every few seconds).

syslogd does not suppress messages, it suppresses *identical* messages.
So what was the *first* message logged by syslogd, the one followed by
"last message repeated XXX times"?

>> Well, your patch disables the work-around exactly for those (really old) cards
>> that actually need it and enables it for those that don't need it.
>
> No, because the test usede for the activation is now the same as the one used
> for the diagnostic, which means that every card which is diagnosed to have the
> bug get the workaround activated.

Umm, no. With your patch, both the diagnostic and the activation are wrong,
whereas before only the diagnostic was wrong.

>> eth0: Sending a multicast list set command from a timer routine........."
>>
>> If you find such messages, the work-around really did something. Otherwise,
>> it's the placebo effect...
>
> Now, I do not get _any_ message in the logs, which means that the network
> cards activity is closer to normality than before the patch.

So your patch did not do you any good. Case closed, as far as the work-around
is concerned.

If you post the original log messages, we might be able to find the real
bug...

[and please don't drop the Cc:]

Ion

--
It is better to keep your mouth shut and be thought a fool,
than to open it and remove all doubt.