Re: [PATCH] eepro100.c, kernel 2.4.1

Augustin Vidovic
2001-02-08T11:14:20Z

On Thu, Feb 08, 2001 at 03:00:10AM -0800, Ion Badulescu wrote:
> > At the same time, the /var/log/messages receives thousands of messages from the
> > NET: subsystem.
>
> So what _were_ those messages? Can you post them?

No I can't because they were suppressed by the syslogd (DOS protection), only
their number being reported (several thousands every few seconds).

> > Since the dmesg of the kernel tells about a work-around for such a bug, I was assuming
> > that the work around was activated, but I had a doubt and after looking at the source,
> > I discovered that it wasn't.
>
> Well, your patch disables the work-around exactly for those (really old) cards
> that actually need it and enables it for those that don't need it.

No, because the test usede for the activation is now the same as the one used
for the diagnostic, which means that every card which is diagnosed to have the
bug get the workaround activated.

> > Now, as Ion says, maybe it is not the "receiver lock-up bug" itself which is
> > worked-around, frankly I don't know.
>
> eth0: Sending a multicast list set command from a timer routine........."
>
> If you find such messages, the work-around really did something. Otherwise,
> it's the placebo effect...

Now, I do not get _any_ message in the logs, which means that the network
cards activity is closer to normality than before the patch.

--
Augustin Vidovic http://www.vidovic.org/augustin/
"Nous sommes tous quelque chose de naissance, musicien ou assassin,
mais il faut apprendre le maniement de la harpe ou du couteau."