From: Pavel Machek <pavel@suse.cz>
To: Manfred Spraul <manfred@colorfullife.com>,
Linus Torvalds <torvalds@transmeta.com>,
linux-kernel@vger.kernel.org
Subject: Re: [beta patch] SSE copy_page() / clear_page()
Date: Tue, 20 Feb 2001 18:35:13 +0100 [thread overview]
Message-ID: <20010220183513.B5102@bug.ucw.cz> (raw)
In-Reply-To: <3A846C84.109F1D7D@colorfullife.com> <200102092240.OAA15902@penguin.transmeta.com> <3A8B08C7.BD79E3B4@colorfullife.com>
In-Reply-To: <3A8B08C7.BD79E3B4@colorfullife.com>; from Manfred Spraul on Wed, Feb 14, 2001 at 11:37:59PM +0100
Hi!
> --- 2.4/mm/filemap.c Wed Feb 14 10:51:42 2001
> +++ build-2.4/mm/filemap.c Wed Feb 14 22:11:44 2001
> @@ -1248,6 +1248,20 @@
> size = count;
>
> kaddr = kmap(page);
> + if (size > 128) {
> + int i;
> + __asm__ __volatile__(
> + "mov %1, %0\n\t"
> + : "=r" (i)
> + : "r" (kaddr+offset)); /* load tlb entry */
> + for(i=0;i<size;i+=64) {
> + __asm__ __volatile__(
> + "prefetchnta (%1, %0)\n\t"
> + "prefetchnta 32(%1, %0)\n\t"
> + : /* no output */
> + : "r" (i), "r" (kaddr+offset));
> + }
> + }
> left = __copy_to_user(desc->buf, kaddr + offset, size);
> kunmap(page);
This seems bogus -- you need to handle faults --
i.e. __prefetchnta_to_user() ;-).
Pavel
--
I'm pavel@ucw.cz. "In my country we have almost anarchy and I don't care."
Panos Katsaloulis describing me w.r.t. patents at discuss@linmodems.org
next prev parent reply other threads:[~2001-02-20 20:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-09 22:17 [beta patch] SSE copy_page() / clear_page() Manfred Spraul
2001-02-09 22:40 ` Linus Torvalds
2001-02-09 23:03 ` Doug Ledford
2001-02-10 9:09 ` Manfred Spraul
2001-02-10 17:18 ` Doug Ledford
2001-02-10 18:00 ` Manfred Spraul
2001-02-10 18:18 ` Manfred Spraul
[not found] ` <200102092240.OAA15902@penguin.transmeta.com>
2001-02-14 22:37 ` Manfred Spraul
2001-02-16 15:27 ` Andrew Morton
2001-02-20 17:35 ` Pavel Machek [this message]
2001-02-20 20:49 ` Alan Cox
2001-02-20 20:52 ` Pavel Machek
2001-02-20 21:08 ` Alan Cox
2001-02-20 21:16 ` Manfred Spraul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010220183513.B5102@bug.ucw.cz \
--to=pavel@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox