Re: plugging in 2.4. Does it work?

Jens Axboe
2001-02-20T22:58:53Z

On Tue, Feb 20 2001, Peter T. Breuer wrote:
> int my_end_request(struct request *req) {
> unsigned long flags; int dequeue = 0;
> spin_lock_irqsave(&io_request_lock, flags);
> if (!req->errors) {
> while (req->nr_sectors > 0) {
> printk( KERN_DEBUG "running end_first on req with %d sectors\n",
> req->nr_sectors);
> if (!end_that_request_first (req, !req->errors, DEVICE_NAME))
> break;
> }
> }
> printk( KERN_DEBUG "running end_first on req with %d sectors\n",
> req->nr_sectors);
> if (!end_that_request_first (req, !req->errors, DEVICE_NAME)) {
> printk( KERN_DEBUG "running end_last on req with %d sectors\n",
> req->nr_sectors);
> end_that_request_last(req);
> dequeue = 1;
> }
> spin_unlock_irqrestore(&io_request_lock, flags);
> return dequeue;
> }

Forgot to mention that the above doesn't make much sense at all. If
there are no errors, you loop through ending all the buffers. Then
you fall through and end the the first (non-existant) chunk? And
end_that_request_first does not need to hold the io_request_lock,
you can move that down to protect end_that_request_last.

--
Jens Axboe