Re: 242-ac3 loop bug

Jens Axboe
2001-02-24T23:15:28Z

[-- Attachment #1: Type: text/plain, Size: 841 bytes --]

On Sat, Feb 24 2001, Mark Swanson wrote:
> First, good job on the loop device. It's rock stable for me - except

thanks, glad to hear it.

> when I try to load the blowfish module which oops the kernel and
> crashes the loop device:-) No problem, I just use another cipher.

cipher bug or? never the less, could you ksymoops that and send
it along?

> The bug I'm reporting is that when a loop device is in use the load of
> the machine stays at 1.00 even though nothing is happening. If I umount
> the loop filesystem the load goes down to 0.00.
>
> > ps -aux | grep loop
> 1674 tty1 DW< 0:00 [loop0]
>
> The system is doing nothing to the loop filesystem.
> Strange that the process isn't logging any cpu usage time. It's
> definately responsible for the 1.00 load.

Oops, this slipped by me. Patch should fix it.

--
Jens Axboe

[-- Attachment #2: loop_sig-1 --]
[-- Type: text/plain, Size: 546 bytes --]

--- drivers/block/loop.c~ Sat Feb 24 23:08:38 2001
+++ drivers/block/loop.c Sat Feb 24 23:11:13 2001
@@ -507,7 +507,7 @@
sprintf(current->comm, "loop%d", lo->lo_number);

spin_lock_irq(&current->sigmask_lock);
- siginitsetinv(&current->blocked, sigmask(SIGKILL));
+ sigfillset(&current->blocked);
flush_signals(current);
spin_unlock_irq(&current->sigmask_lock);

@@ -525,7 +525,7 @@
up(&lo->lo_sem);

for (;;) {
- down(&lo->lo_bh_mutex);
+ down_interruptible(&lo->lo_bh_mutex);
if (!atomic_read(&lo->lo_pending))
break;