From: Tim Waugh <twaugh@redhat.com>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: linux-kernel@vger.kernel.org
Subject: [patch] 2.4.2: irq-driven lp stalls
Date: Tue, 27 Feb 2001 22:04:46 +0000 [thread overview]
Message-ID: <20010227220446.U13721@redhat.com> (raw)
Hi Linus,
This patch seems to cure some printing stalls that some people have
been seeing. The down_trylock call isn't really needed there anyway.
Please apply.
Tim.
*/
2001-02-27 Tim Waugh <twaugh@redhat.com>
* drivers/parport/ieee1284_ops.c: Remove down_trylock call,
which seems to prevent stalls.
* drivers/parport/ChangeLog: Updated.
--- linux/drivers/parport/ieee1284_ops.c.sema Tue Feb 27 21:43:49 2001
+++ linux/drivers/parport/ieee1284_ops.c Tue Feb 27 21:44:16 2001
@@ -50,9 +50,6 @@
if (port->irq != PARPORT_IRQ_NONE) {
parport_enable_irq (port);
no_irq = 0;
-
- /* Clear out previous irqs. */
- while (!down_trylock (&port->physport->ieee1284.irq));
}
port->physport->ieee1284.phase = IEEE1284_PH_FWD_DATA;
--- linux/drivers/parport/ChangeLog.sema Tue Feb 27 21:44:21 2001
+++ linux/drivers/parport/ChangeLog Tue Feb 27 21:45:43 2001
@@ -0,0 +1,7 @@
+2001-02-27 Tim Waugh <twaugh@redhat.com>
+
+ * ieee1284_ops.c (parport_ieee1284_write_compat): Don't use
+ down_trylock to reset the IRQ count. Don't even use sema_init,
+ because it's not even necessary to reset the count. I can't
+ remember why we ever did.
+
reply other threads:[~2001-02-27 22:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010227220446.U13721@redhat.com \
--to=twaugh@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox