From: Robert Read <rread@datarithm.net>
To: Marcelo Tosatti <marcelo@conectiva.com.br>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch] set kiobuf io_count once, instead of increment
Date: Wed, 28 Feb 2001 09:18:59 -0800 [thread overview]
Message-ID: <20010228091859.A9540@tenchi.datarithm.net> (raw)
In-Reply-To: <20010227162222.A6389@tenchi.datarithm.net> <Pine.LNX.4.21.0102272234380.7124-100000@freak.distro.conectiva>
In-Reply-To: <Pine.LNX.4.21.0102272234380.7124-100000@freak.distro.conectiva>; from marcelo@conectiva.com.br on Tue, Feb 27, 2001 at 10:50:54PM -0300
On Tue, Feb 27, 2001 at 10:50:54PM -0300, Marcelo Tosatti wrote:
>
>
> It seems your patch breaks bh allocation failure handling. If
> get_unused_buffer_head() fails, iobuf->io_count never reaches 0, so
> processes waiting on kiobuf_wait_for_io() will block forever.
>
This is true, but it looks like the brw_kiovec allocation failure
handling is broken already; it's calling __put_unused_buffer_head on
bhs without waiting for them to complete first. Also, the err won't
be returned if the previous batch of bhs finished ok. It looks like
brw_kiovec needs some work, but I'm going to need some coffee first...
robert
next prev parent reply other threads:[~2001-02-28 17:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-28 0:22 [patch] set kiobuf io_count once, instead of increment Robert Read
2001-02-28 1:50 ` Marcelo Tosatti
2001-02-28 17:18 ` Robert Read [this message]
2001-03-02 18:46 ` Stephen C. Tweedie
2001-03-02 18:43 ` Stephen C. Tweedie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010228091859.A9540@tenchi.datarithm.net \
--to=rread@datarithm.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox