Re: NBD Cleanup patch and bugfix in ll_rw_blk.c

Jens Axboe
2001-02-25T22:50:04Z

On Sun, Feb 25 2001, Russell King wrote:
> On Sun, Feb 25, 2001 at 07:57:29PM +0000, Steve Whitehouse wrote:
> > -int nbd_init(void)
> > +int __init nbd_init(void)
>
> > -void cleanup_module(void)
> > +void __exit nbd_cleanup(void)
>
> > +
> > +module_init(nbd_init);
> > +module_exit(nbd_cleanup);
>
> If you're using module_init/module_exit, shouldn't nbd_init/nbd_cleanup
> be declared statically?

And more importantly, the init calls from ll_rw_blk.c:blk_dev_init()
should be removed too.

--
Jens Axboe