From: Andrey Panin <pazke@orbita.don.sitek.net>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] bug in /drivers/char/epca.c
Date: Tue, 6 Mar 2001 15:28:47 +0300 [thread overview]
Message-ID: <20010306152847.A30541@debian> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 505 bytes --]
Hi all,
this patch fixes bug in Digi epca.c driver. This driver calls
tty_register_driver() 3 times and tty_unregister_driver() 2 times.
This bug causes hang on module unload.
Also a question: somebody knows why this driver scans PCI devices before
registering tty drivers? It makes impossible to remove panic() calls easily.
Best regards.
--
Andrey Panin | Embedded systems software engineer
pazke@orbita1.ru | PGP key: http://www.orbita1.ru/~pazke/AndreyPanin.asc
[-- Attachment #1.2: patch-epca --]
[-- Type: text/plain, Size: 534 bytes --]
diff -ur linux.vanilla/drivers/char/epca.c linux/drivers/char/epca.c
--- linux.vanilla/drivers/char/epca.c Mon Mar 5 12:01:51 2001
+++ linux/drivers/char/epca.c Tue Mar 6 13:37:58 2001
@@ -1574,7 +1574,8 @@
cli();
if ((tty_unregister_driver(&pc_driver)) ||
- (tty_unregister_driver(&pc_callout)))
+ (tty_unregister_driver(&pc_callout)) ||
+ (tty_unregister_driver(&pc_info)))
{
printk(KERN_WARNING "<Error> - DIGI : cleanup_module failed to un-register tty driver\n");
restore_flags(flags);
[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]
reply other threads:[~2001-03-06 12:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010306152847.A30541@debian \
--to=pazke@orbita.don.sitek.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox