From: Jens Axboe <axboe@suse.de>
To: David Mansfield <lkml@dm.ultramaster.com>
Cc: Pierre Etchemaite <petchema@concept-micro.com>,
Jani Jaakkola <jjaakkol@cs.Helsinki.FI>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix a bug in ioctl(CDROMREADAUDIO) in cdrom.c in 2.2
Date: Mon, 19 Mar 2001 12:24:36 +0100 [thread overview]
Message-ID: <20010319122436.Q29105@suse.de> (raw)
In-Reply-To: <XFMail.20010315140400.petchema@concept-micro.com> <3AB264F2.7D19842F@dm.ultramaster.com>
In-Reply-To: <3AB264F2.7D19842F@dm.ultramaster.com>; from lkml@dm.ultramaster.com on Fri, Mar 16, 2001 at 02:09:38PM -0500
On Fri, Mar 16 2001, David Mansfield wrote:
> > Same thing for 2.4.2.
> >
> > Is my allocation loop "over engineering", or just plain bad thing to do ?
> >
>
> I've been running this (or close: my version tries 8 frames, then jumps
> immediately to 1, without trying 4 and 2 in between if the kmalloc
> fails) since it was changed. Without such a patch, my CDDA read speed
> drops to 25% the original rate. You also have the fix that started the
> thread!
>
> Jens (cdrom maintainer) said he was working on a more elegant solution,
> but to me, such a simple fix as yours should go in the kernel in the
> meantime. Jens?
I haven't integrated it yet, because of the vm printing memory
allocations errors. Which sort of destroys the idea of doing "clever"
allocations like this.
--
Jens Axboe
prev parent reply other threads:[~2001-03-19 11:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-03-14 14:17 [PATCH] fix a bug in ioctl(CDROMREADAUDIO) in cdrom.c in 2.2.18 Jani Jaakkola
2001-03-15 13:04 ` [PATCH] fix a bug in ioctl(CDROMREADAUDIO) in cdrom.c in 2.2 Pierre Etchemaite
2001-03-16 19:09 ` David Mansfield
2001-03-19 11:24 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010319122436.Q29105@suse.de \
--to=axboe@suse.de \
--cc=jjaakkol@cs.Helsinki.FI \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml@dm.ultramaster.com \
--cc=petchema@concept-micro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox