From: "Stephen C. Tweedie" <sct@redhat.com>
To: linux-kernel@vger.kernel.org, torvalds@transmeta.com,
alan@lxorguk.ukuu.org.uk, Alexander Viro <viro@math.psu.edu>,
"Stephen C. Tweedie" <sct@redhat.com>
Subject: Re: 2.4.2 fs/inode.c
Date: Thu, 22 Mar 2001 19:04:52 +0000 [thread overview]
Message-ID: <20010322190452.C7756@redhat.com> (raw)
In-Reply-To: <20010322134215.A25508@cs.cmu.edu>
In-Reply-To: <20010322134215.A25508@cs.cmu.edu>; from jaharkes@cs.cmu.edu on Thu, Mar 22, 2001 at 01:42:15PM -0500
Hi,
On Thu, Mar 22, 2001 at 01:42:15PM -0500, Jan Harkes wrote:
>
> I found some code that seems wrong and didn't even match it's comment.
> Patch is against 2.4.2, but should go cleanly against 2.4.3-pre6 as well.
Patch looks fine to me. Have you tested it? If this goes wrong,
things break badly...
> /* Don't do this for I_DIRTY_PAGES - that doesn't actually dirty the inode itself */
> - if (flags & (I_DIRTY | I_DIRTY_SYNC)) {
> + if (flags & (I_DIRTY_SYNC | I_DIRTY_DATASYNC)) {
--Stephen
next prev parent reply other threads:[~2001-03-22 19:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-03-22 18:42 2.4.2 fs/inode.c Jan Harkes
2001-03-22 19:04 ` Stephen C. Tweedie [this message]
2001-03-22 19:32 ` Jan Harkes
2001-03-22 20:21 ` Chris Mason
2001-03-26 17:51 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010322190452.C7756@redhat.com \
--to=sct@redhat.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox