public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Eric S. Raymond" <esr@thyrsus.com>
To: Peter Samuelson <peter@cadcamlab.org>
Cc: "Eric S. Raymond" <esr@snark.thyrsus.com>,
	linux-kernel@vger.kernel.org, kbuild-devel@lists.sourceforge.net
Subject: Re: CML1 cleanup patch
Date: Mon, 26 Mar 2001 01:32:28 -0500	[thread overview]
Message-ID: <20010326013228.A11181@thyrsus.com> (raw)
In-Reply-To: <200103260001.f2Q01Yt09387@snark.thyrsus.com> <15038.56527.591553.87791@wire.cadcamlab.org>
In-Reply-To: <15038.56527.591553.87791@wire.cadcamlab.org>; from peter@cadcamlab.org on Mon, Mar 26, 2001 at 12:08:15AM -0600

Peter Samuelson <peter@cadcamlab.org>:
> > CONFIG_8139TOO			CONFIG_RTL8139TOO
> > CONFIG_8139TOO_PIO		CONFIG_RTL8139TOO_PIO
> > CONFIG_8139TOO_TUNE_TWISTER	CONFIG_RTL8139TOO_TUNE_TWISTER
> 
> The -TOO suffix was to distinguish between this and the former 8139
> driver, as the two coexisted in 2.2 and 2.3.  As the old driver has
> been dropped from 2.4, I propose likewise dropping the -TOO.

I'm preparing an updated version of the patch for 2.4.3-pre8.  I'll
incorporate this change.
 
> Oh, BTW -- an alternate approach to making the kernel tree compatible
> with CML2 would be to make CML2 compatible with the kernel tree.
> Define a character (say '%') as an optional prefix for a configuration
> symbol.  This character would only be required where the symbol would
> otherwise by misparsed, as with '[0-9].*'.

I considered two workarounds:

1. Adding some cruft to the language to support this case, as you suggest.

I might have gone this route, until I tripped over the two bugs and
the bad config symbols in the CRIS port tree.  That meant there was
going to have to be a cleanup patch anyway, so why not fix those 20 
symbols (out of 1831) rather than grubbifying the language?

2. Hacking the CML2 lexical analyzer to handle this case.

I could have done this, allowing tokens to be recognized as numeric only
if all chars are digits.  I didn't, for two reasons: (1) Lexical analysis
is, as it turns out, a hotspot in the CML2 compiler code -- the last thing
it needs is more overhead, and (2) interpreting symbols with leading digits
as nonnumeric tokens is just *wrong*.  Ugh.  Violates the Principle of Least
Surprise big-time.
-- 
		<a href="http://www.tuxedo.org/~esr/">Eric S. Raymond</a>

Every election is a sort of advance auction sale of stolen goods. 
	-- H.L. Mencken 

  parent reply	other threads:[~2001-03-26  6:29 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200103260001.f2Q01Yt09387@snark.thyrsus.com>
2001-03-26  6:08 ` CML1 cleanup patch Peter Samuelson
2001-03-26  6:24   ` Jeff Garzik
2001-03-26  6:42     ` Jeff Garzik
2001-03-26  7:09       ` Eric S. Raymond
2001-03-26  7:20         ` Jeff Garzik
2001-03-26  7:30           ` Eric S. Raymond
2001-03-26  7:37             ` Jeff Garzik
2001-03-26  7:28         ` [kbuild-devel] " Keith Owens
2001-03-26  7:43           ` Jeff Garzik
2001-03-26  7:52             ` Eric S. Raymond
2001-03-26 14:34       ` Rik van Riel
2001-03-26  6:49     ` Eric S. Raymond
2001-03-26  7:01       ` Jeff Garzik
2001-03-26  7:02       ` Alan Cox
2001-03-26  7:12         ` Eric S. Raymond
2001-03-26 14:43           ` Alan Cox
2001-03-26  7:22       ` Peter Samuelson
2001-03-26  7:40         ` Eric S. Raymond
2001-03-26  6:32   ` Eric S. Raymond [this message]
2001-03-26 11:57     ` [kbuild-devel] " John Cowan
2001-03-26 14:55       ` Rik van Riel
2001-03-26 17:54         ` Eric S. Raymond
2001-04-15  9:07         ` Kai Henningsen
2001-04-15 20:52           ` Olaf Titz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010326013228.A11181@thyrsus.com \
    --to=esr@thyrsus.com \
    --cc=esr@snark.thyrsus.com \
    --cc=kbuild-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter@cadcamlab.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox