From: David Hinds <dhinds@sonic.net>
To: Keith Owens <kaos@ocs.com.au>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.2.19 aic7xxx breaks pcmcia
Date: Mon, 26 Mar 2001 08:48:09 -0800 [thread overview]
Message-ID: <20010326084809.A11493@sonic.net> (raw)
In-Reply-To: <22779.985590853@ocs3.ocs-net>
In-Reply-To: <22779.985590853@ocs3.ocs-net>; from Keith Owens on Mon, Mar 26, 2001 at 05:14:13PM +1000
On Mon, Mar 26, 2001 at 05:14:13PM +1000, Keith Owens wrote:
> 2.2.19 Documentation/Changes says pcmcia-cs 3.0.14. I am using 3.1.21
> and it breaks if you compile the kernel with scsi support then try to
> compile pcmcia. clients/apa1480_stub.c in 3.1.21 has
> #include <../drivers/scsi/aic7xxx.h>
> but in 2.2.19 that file is drivers/scsi/aic7xxx/aic7xxx.h. You need at
> least pcmcia-cs 3.1.25 for kernel 2.2.19 with scsi support.
Correct. It is not just the header file that is at issue, though; the
whole build procedure for the aic7xxx driver changed.
> In the kernel and associated utilities I want to remove lines like
> #include <../drivers/scsi/aic7xxx.h>
> and replace them with
> #include "aic7xxx.h"
> with the Makefile specifying -I $(TOPDIR)/drivers/scsi (2.2.18) or -I
> $(TOPDIR)/drivers/scsi/aic7xxx (2.2.19). Hard coding long path names
> for #include is bad, especially when they contain '..'. It stops
> kernel developers moving code around and makes it difficult to do some
> of the things I plan for the 2.5 Makefile rewrite. David, how easy
> would it be to change pcmcia to this style of include?
It would not be too hard to do what you suggest, but would make for
very long CPPFLAGS. Which is inconvenient if you like to actually see
what's going on when you do a build. I think more of the include
files at issue should probably be in the kernel include tree, and not
hidden in the driver tree. That would make the issue moot.
What are the things you're planning that will cause trouble? I would
also think it would be less of an issue with 2.5 if there is some hope
that in-kernel PCMCIA is going to be the standard.
-- Dave
next prev parent reply other threads:[~2001-03-26 16:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-03-26 7:14 2.2.19 aic7xxx breaks pcmcia Keith Owens
2001-03-26 16:48 ` David Hinds [this message]
2001-03-26 22:20 ` Keith Owens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010326084809.A11493@sonic.net \
--to=dhinds@sonic.net \
--cc=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox