public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Oleg Drokin <green@ixcelerator.com>
To: Manoj Sontakke <manojs@sasken.com>
Cc: Oleg Drokin <green@dredd.crimea.edu>,
	linux-kernel@vger.kernel.org, davem@redhat.com,
	kuznet@ms2.inr.ac.ru
Subject: Re: IP layer bug?
Date: Mon, 26 Mar 2001 10:09:41 +0400	[thread overview]
Message-ID: <20010326100941.A16800@iXcelerator.com> (raw)
In-Reply-To: <20010325005731.A5243@dredd.crimea.edu> <Pine.LNX.4.21.0103261555250.25563-100000@pcc65.sasi.com>
In-Reply-To: <Pine.LNX.4.21.0103261555250.25563-100000@pcc65.sasi.com>; from manojs@sasken.com on Mon, Mar 26, 2001 at 04:06:19PM +0530

Hello!

On Mon, Mar 26, 2001 at 04:06:19PM +0530, Manoj Sontakke wrote:
> >    2.4.x kernel. have not tried 2.2
> >    I just found somethig, I believe is kernel bug.
> >    I am working with usbnet.c driver, which stores some of its
> >    internal state in sk_buff.cb area. But once such skb passed to
> >    upper layer with netif_rx, net/ipv4/ip_input.c reuses content of cb
> >    (line #345), 
> ip_options_compile() when called with first argument NULL resets cb to 0.
I have found that already.

> This is probably because the cb is supposed to be used IP and above. The
Sure.

> underlying layer(link and phy) could be anything so where from the
> ip_options should start will depend upon the underlying layer.
But here's the problem!
If I won't zero cb in my driver before netif_rx() call,
IP layer thinks that all my packets have various ip options set
(source routing most notable)

Bye,
    Oleg

  reply	other threads:[~2001-03-26  6:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-03-24 21:57 IP layer bug? Oleg Drokin
2001-03-26 10:36 ` Manoj Sontakke
2001-03-26  6:09   ` Oleg Drokin [this message]
2001-03-26 12:21     ` Manoj Sontakke
2001-03-26  7:02       ` Oleg Drokin
2001-03-30 17:13 ` kuznet
2001-03-31 15:03   ` Oleg Drokin
2001-03-31 15:32     ` kuznet
2001-04-02  9:25       ` Oleg Drokin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010326100941.A16800@iXcelerator.com \
    --to=green@ixcelerator.com \
    --cc=davem@redhat.com \
    --cc=green@dredd.crimea.edu \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manojs@sasken.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox