From: Oleg Drokin <green@ixcelerator.com>
To: kuznet@ms2.inr.ac.ru
Cc: Oleg Drokin <green@dredd.crimea.edu>,
linux-kernel@vger.kernel.org, davem@redhat.com,
david-b@pacbell.net
Subject: Re: IP layer bug?
Date: Mon, 2 Apr 2001 13:25:08 +0400 [thread overview]
Message-ID: <20010402132508.A13238@iXcelerator.com> (raw)
In-Reply-To: <20010331190314.A27130@dredd.crimea.edu> <200103311532.TAA20809@ms2.inr.ac.ru>
In-Reply-To: <200103311532.TAA20809@ms2.inr.ac.ru>; from kuznet@ms2.inr.ac.ru on Sat, Mar 31, 2001 at 07:32:48PM +0400
Hello!
On Sat, Mar 31, 2001 at 07:32:48PM +0400, kuznet@ms2.inr.ac.ru wrote:
> General rule is minimization redundant clearings of the area.
> > Why not document it somewhere, so that others will not fall into the same trap?
> Indeed. 8) You got the experience, which you expect to be useful
> for people, it is time to prepare some note recording this. 8)
I cannot think of something better that piece below, so I think
you may want to change it, anyway ;)
--- include/linux/skbuff.h.orig Mon Apr 2 13:13:46 2001
+++ include/linux/skbuff.h Mon Apr 2 13:24:18 2001
@@ -102,7 +102,10 @@
* This is the control buffer. It is free to use for every
* layer. Please put your private variables there. If you
* want to keep them across layers you have to do a skb_clone()
- * first. This is owned by whoever has the skb queued ATM.
+ * first (which is a must, anyway). This is owned by whoever
+ * has the skb queued ATM.
+ * Driver writers: notice you should zero cb before netif_rx()
+ * if you used it.
*/
char cb[48];
Bye,
Oleg
prev parent reply other threads:[~2001-04-02 9:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-03-24 21:57 IP layer bug? Oleg Drokin
2001-03-26 10:36 ` Manoj Sontakke
2001-03-26 6:09 ` Oleg Drokin
2001-03-26 12:21 ` Manoj Sontakke
2001-03-26 7:02 ` Oleg Drokin
2001-03-30 17:13 ` kuznet
2001-03-31 15:03 ` Oleg Drokin
2001-03-31 15:32 ` kuznet
2001-04-02 9:25 ` Oleg Drokin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010402132508.A13238@iXcelerator.com \
--to=green@ixcelerator.com \
--cc=davem@redhat.com \
--cc=david-b@pacbell.net \
--cc=green@dredd.crimea.edu \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox