From: Jens Axboe <axboe@suse.de>
To: "Heinz J. Mauelshagen" <Mauelshagen@Sistina.com>
Cc: Herbert Valerio Riedel <hvr@hvrlab.org>,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@transmeta.com>,
linux-lvm-patch@EZ-Darmstadt.Telekom.de
Subject: Re: /dev/loop0 over lvm... leading to d-state :-(
Date: Thu, 5 Apr 2001 17:37:31 +0200 [thread overview]
Message-ID: <20010405173731.C5187@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.30.0104042152490.1183-100000@janus.txd.hvrlab.org> <20010405071313.A418@suse.de> <20010405163818.M418@suse.de> <20010405164942.N418@suse.de> <20010405163239.F6981@sistina.com>
In-Reply-To: <20010405163239.F6981@sistina.com>; from Mauelshagen@Sistina.com on Thu, Apr 05, 2001 at 04:32:39PM +0000
On Thu, Apr 05 2001, Heinz J. Mauelshagen wrote:
> > Irks, another one. lvm_make_request_fn also needs to call b_end_io
> > if a map fails.
>
> This is wrong.
>
> In case of an io error we do already call buffer_IO_error() on 2.4 in
> lvm_map().
Where? Calling buffer_IO_error would be ok, but there are no such calls
in 2.4.3. I just stated elsewhere that submit_bh should probably be
clearing the dirty bit, not ll_rw_block, in which case the b_end_io
is fine. But buffer_IO_error is probably more clear. I trust you'll
take care of that part then.
--
Jens Axboe
next prev parent reply other threads:[~2001-04-05 15:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-04-04 20:00 /dev/loop0 over lvm... leading to d-state :-( Herbert Valerio Riedel
2001-04-05 5:13 ` Jens Axboe
2001-04-05 14:38 ` Jens Axboe
2001-04-05 14:49 ` Jens Axboe
2001-04-05 16:32 ` Heinz J. Mauelshagen
2001-04-05 15:37 ` Jens Axboe [this message]
2001-04-05 16:52 ` Heinz J. Mauelshagen
2001-04-05 15:54 ` Jens Axboe
2001-04-05 17:10 ` Heinz J. Mauelshagen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010405173731.C5187@suse.de \
--to=axboe@suse.de \
--cc=Mauelshagen@Sistina.com \
--cc=hvr@hvrlab.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-lvm-patch@EZ-Darmstadt.Telekom.de \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox