* aic7xxx 6.1.10 and 2.4.4-pre1
@ 2001-04-07 21:55 lists
2001-04-07 23:24 ` Justin T. Gibbs
0 siblings, 1 reply; 7+ messages in thread
From: lists @ 2001-04-07 21:55 UTC (permalink / raw)
To: Justin T. Gibbs; +Cc: J . A . Magallon, Linux Kernel
I had tried 6.1.8 + 2.4.3 and had problems which included messages like
'aic7xxx_abort returns 8194' and machine froze up shortly after X started.
This on redhat 7.0. Sorry but since I was unable to even boot back the
prev kernel (2.4.0) I cant provide any more detailed information. I have
been following to see a few other folks have had some issues with scsi as well.
I have 2 lvd scsi disks and one ide, AH 2940U2 - top of lilo included below -
and bios boot order is scsi first.
So I started again - installed redhat 7.0.9.
took 2.4.4-pre1 and patched it with
linux-aic7xxx-6.1.10-2.4.3.patch
Patch applied cleanly but when I compile it complains a little:
In file included from aic7xxx_linux.c:131:
aic7xxx_osm.h: In function `ahc_pci_read_config':
aic7xxx_osm.h:862: warning: control reaches end of non-void function
(for several .c files but always refers to 'ahc_pci_read_config')
In file included from ... include/linux/raid/md.h:50,
from init/main.c:24: ..include/linux/raid/md_k.h: In function `pers_to_level':
raid/md_k.h:39: warning: control reaches end of non-void function
Do I need to be concerned here? I dont whether the presumed missing return is
a bad thing or not.
I have not yet tried to boot this kernel.
Also
# lilo.conf
boot=/dev/sda
disk=/dev/sda
bios=0x80
disk=/dev/sdb
bios=0x81
disk=/dev/hda
bios=0x82
map=/boot/map
install=/boot/boot.b
prompt
timeout=50
message=/boot/message
lba32
default=linux
...
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: aic7xxx 6.1.10 and 2.4.4-pre1
2001-04-07 21:55 aic7xxx 6.1.10 and 2.4.4-pre1 lists
@ 2001-04-07 23:24 ` Justin T. Gibbs
2001-04-08 0:22 ` J . A . Magallon
0 siblings, 1 reply; 7+ messages in thread
From: Justin T. Gibbs @ 2001-04-07 23:24 UTC (permalink / raw)
To: lists; +Cc: J . A . Magallon, Linux Kernel
> So I started again - installed redhat 7.0.9.
> took 2.4.4-pre1 and patched it with
> linux-aic7xxx-6.1.10-2.4.3.patch
>
> Patch applied cleanly but when I compile it complains a little:
>
> In file included from aic7xxx_linux.c:131:
> aic7xxx_osm.h: In function `ahc_pci_read_config':
> aic7xxx_osm.h:862: warning: control reaches end of non-void function
>
> (for several .c files but always refers to 'ahc_pci_read_config')
This is because panic() is not marked as a "no return" function. So,
GCC compains that, in the panic() case, we don't return a value from
this particular function. Since we will never return in that case,
it is, at least in the aic7xxx driver, a harmless warning.
--
Justin
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: aic7xxx 6.1.10 and 2.4.4-pre1
2001-04-07 23:24 ` Justin T. Gibbs
@ 2001-04-08 0:22 ` J . A . Magallon
2001-04-08 1:41 ` Justin T. Gibbs
0 siblings, 1 reply; 7+ messages in thread
From: J . A . Magallon @ 2001-04-08 0:22 UTC (permalink / raw)
To: Justin T . Gibbs; +Cc: Linux Kernel
On 04.08 Justin T. Gibbs wrote:
> >
> > In file included from aic7xxx_linux.c:131:
> > aic7xxx_osm.h: In function `ahc_pci_read_config':
> > aic7xxx_osm.h:862: warning: control reaches end of non-void function
>
> This is because panic() is not marked as a "no return" function. So,
linux/include/linux/kernel.h +38:
# define NORET_TYPE /**/
# define ATTRIB_NORET __attribute__((noreturn))
# define NORET_AND noreturn,
..
NORET_TYPE void panic(const char * fmt, ...)
__attribute__ ((NORET_AND format (printf, 1, 2)));
^^^^^^^^^
Similar cases, compare include/linux/raid/md_k.h:pers_to_level() in
2.4.3 and 2.4.3-ac3.
--
J.A. Magallon # Let the source
mailto:jamagallon@able.es # be with you, Luke...
Linux werewolf 2.4.3-ac3 #1 SMP Thu Apr 5 00:28:45 CEST 2001 i686
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: aic7xxx 6.1.10 and 2.4.4-pre1
2001-04-08 0:22 ` J . A . Magallon
@ 2001-04-08 1:41 ` Justin T. Gibbs
0 siblings, 0 replies; 7+ messages in thread
From: Justin T. Gibbs @ 2001-04-08 1:41 UTC (permalink / raw)
To: J . A . Magallon; +Cc: Linux Kernel
>NORET_TYPE void panic(const char * fmt, ...)
> __attribute__ ((NORET_AND format (printf, 1, 2)));
> ^^^^^^^^^
>
>Similar cases, compare include/linux/raid/md_k.h:pers_to_level() in
>2.4.3 and 2.4.3-ac3.
Then gcc is not honoring the attribute. The only way for that
function to not return with a value is in the panic case and that
cannot happen.
--
Justin
^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <20010407195031.B25801@sapience.com>]
end of thread, other threads:[~2001-04-09 21:20 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-04-07 21:55 aic7xxx 6.1.10 and 2.4.4-pre1 lists
2001-04-07 23:24 ` Justin T. Gibbs
2001-04-08 0:22 ` J . A . Magallon
2001-04-08 1:41 ` Justin T. Gibbs
[not found] <20010407195031.B25801@sapience.com>
[not found] ` <200104080139.f381dZs92143@aslan.scsiguy.com>
2001-04-08 4:11 ` lists
2001-04-08 4:42 ` lists
2001-04-09 21:19 ` Justin T. Gibbs
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox