From: Pavel Machek <pavel@suse.cz>
To: Dawson Engler <engler@csl.Stanford.EDU>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [CHECKER] __init functions called by non-__init
Date: Sat, 7 Apr 2001 21:29:32 +0000 [thread overview]
Message-ID: <20010407212932.A34@(none)> (raw)
In-Reply-To: <200104050649.XAA22384@csl.Stanford.EDU>
In-Reply-To: <200104050649.XAA22384@csl.Stanford.EDU>; from engler@csl.Stanford.EDU on Wed, Apr 04, 2001 at 11:49:48PM -0700
Hi!
> 1. The best case: an init function calls a non-init, which in
> turn calls an init:
>
> void __init probe() { a(); }
> void a() { b(); }
> void __init b() { ... }
> in this case, is the missing __init on 'a' only a performance
> bug in that a's code won't be freed up?
...not neccesarily an error. If a() is being used to do stuff needed at
runtime, and only calls b() at initialzation.
> On the other hand, if I understood the rules right, this next one looks like
> a more exciting error, since an __exit routine is calling an __init routine:
Actually, it is right for subtle reasons:
__exit is only used in module case. And in module case __init functions are
not freed.
Pavel
--
Philips Velo 1: 1"x4"x8", 300gram, 60, 12MB, 40bogomips, linux, mutt,
details at http://atrey.karlin.mff.cuni.cz/~pavel/velo/index.html.
prev parent reply other threads:[~2001-04-09 20:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-04-05 6:49 [CHECKER] __init functions called by non-__init Dawson Engler
2001-04-06 19:31 ` Rusty Russell
2001-04-06 19:32 ` David S. Miller
2001-04-07 21:29 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20010407212932.A34@(none)' \
--to=pavel@suse.cz \
--cc=engler@csl.Stanford.EDU \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox