From: Andrea Arcangeli <andrea@suse.de>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Re: softirq buggy
Date: Mon, 9 Apr 2001 15:50:52 +0200 [thread overview]
Message-ID: <20010409155052.H7108@athlon.random> (raw)
In-Reply-To: <200104081758.VAA15670@ms2.inr.ac.ru> <3AD0D9A8.189AA43C@colorfullife.com>
In-Reply-To: <3AD0D9A8.189AA43C@colorfullife.com>; from manfred@colorfullife.com on Sun, Apr 08, 2001 at 11:35:36PM +0200
On Sun, Apr 08, 2001 at 11:35:36PM +0200, Manfred Spraul wrote:
> I've attached a new patch:
>
> * cpu_is_idle() moved to <linux/pm.h>
> * function uninlined due to header dependencies
> * cpu_is_idle() doesn't call do_softirq directly, instead the caller
> returns to schedule()
> * cpu_is_idle() exported for modules.
> * docu updated.
>
> I'd prefer to inline cpu_is_idle(), but optimizing the idle code path is
> probably not that important ;-)
your cpu_is_idle will return 0 in the need_resched != 0 check even if the cpu
is idle (because of the -1 trick for avoiding the SMP-IPI to notify the cpu).
The issue you are addressing is quite londstanding and it is not only related
to the loop with an idle cpu.
This is the way I prefer to fix it:
ftp://ftp.us.kernel.org/pub/linux/kernel/people/andrea/patches/v2.4/2.4.4pre1/ksoftirqd-1
Andrea
next prev parent reply other threads:[~2001-04-09 13:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <000401c0b319517fea9@local>
2001-03-25 23:10 ` Serial port latency Pavel Machek
2001-03-29 7:58 ` Manfred Spraul
2001-03-30 22:36 ` Pavel Machek
2001-03-31 22:09 ` Manfred Spraul
2001-04-03 23:07 ` softirq buggy [Re: Serial port latency] Pavel Machek
2001-04-04 21:18 ` Manfred Spraul
2001-04-06 12:00 ` Pavel Machek
2001-04-07 22:28 ` Manfred Spraul
2001-04-08 16:58 ` kuznet
2001-04-08 17:21 ` Manfred Spraul
2001-04-08 17:58 ` kuznet
2001-04-08 18:16 ` Manfred Spraul
2001-04-08 21:35 ` [PATCH] Re: softirq buggy Manfred Spraul
2001-04-09 8:42 ` Albert D. Cahalan
2001-04-09 13:50 ` Andrea Arcangeli [this message]
2001-04-09 15:26 ` Manfred Spraul
2001-04-09 17:31 ` Andrea Arcangeli
2001-04-09 17:48 ` kuznet
2001-04-09 18:26 ` Andrea Arcangeli
2001-04-10 0:37 ` Serial port latency Andrea Arcangeli
2001-04-09 11:37 [PATCH] Re: softirq buggy Studierende der Universitaet des Saarlandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010409155052.H7108@athlon.random \
--to=andrea@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox