public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "W. Michael Petullo" <mike@flyn.org>
To: gniibe@mri.co.jp, linux-kernel@vger.kernel.org
Subject: patch for PLIP and slow, interrupt-less computers
Date: Thu, 12 Apr 2001 16:46:53 -0400	[thread overview]
Message-ID: <20010412164653.A10864@dragon.flyn.org> (raw)

I have written a quick patch for the PLIP driver contained in the 2.4.3
version of the Linux kernel.  This patch allows one to use PLIP with
computers which have an interrupt-less parallel port and a slow processor.
The stock PLIP driver constantly times out on my 80486-based laptop.
This patch adds the ability to specify two key values, trigger_wait and
nibble_wait, when loading the PLIP driver.

Using this patch and adding the following entry to the modules.conf file
on the computers on either side of my PLIP link makes the connection
work nicely:

# Because my laptop is so slow.
options plip                    trigger_wait=50000 nibble_wait=300000

Here is the patch:

================================================================================

--- plip.c	Tue Feb 13 16:15:05 2001
+++ /tmp/linux/drivers/net/plip.c	Thu Apr 12 16:07:07 2001
@@ -137,10 +137,10 @@
 #define PLIP_DELAY_UNIT		   1
 
 /* Connection time out = PLIP_TRIGGER_WAIT * PLIP_DELAY_UNIT usec */
-#define PLIP_TRIGGER_WAIT	 500
+static unsigned long trigger_wait = 500;
 
 /* Nibble time out = PLIP_NIBBLE_WAIT * PLIP_DELAY_UNIT usec */
-#define PLIP_NIBBLE_WAIT        3000
+static unsigned long nibble_wait = 3000;
 
 /* Bottom halves */
 static void plip_kick_bh(struct net_device *dev);
@@ -345,8 +345,8 @@
 	nl->port_owner = 0;
 
 	/* Initialize constants */
-	nl->trigger	= PLIP_TRIGGER_WAIT;
-	nl->nibble	= PLIP_NIBBLE_WAIT;
+	nl->trigger	= trigger_wait;
+	nl->nibble	= nibble_wait;
 
 	/* Initialize task queue structures */
 	INIT_LIST_HEAD(&nl->immediate.list);
@@ -1297,6 +1297,8 @@
 
 MODULE_PARM(parport, "1-" __MODULE_STRING(PLIP_MAX) "i");
 MODULE_PARM(timid, "1i");
+MODULE_PARM(trigger_wait, "i");
+MODULE_PARM(nibble_wait, "i");
 
 static struct net_device *dev_plip[PLIP_MAX] = { NULL, };

================================================================================
 
-- 
W. Michael Petullo

:wq

             reply	other threads:[~2001-04-14 15:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-04-12 20:46 W. Michael Petullo [this message]
2001-04-14 17:44 ` patch for PLIP and slow, interrupt-less computers Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010412164653.A10864@dragon.flyn.org \
    --to=mike@flyn.org \
    --cc=gniibe@mri.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox