Re: Linux-Kernel Archive: No 100 HZ timer !

[R.E.Wolff@BitWizard.nl (Rogier Wolff)]

Andre Hedrick wrote:
> 
> Okay but what will be used for a base for hardware that has critical
> timing issues due to the rules of the hardware?
> 
> I do not care but your drives/floppy/tapes/cdroms/cdrws do:
> 
> /*
>  * Timeouts for various operations:
>  */
> #define WAIT_DRQ        (5*HZ/100)      /* 50msec - spec allows up to 20ms */
> #ifdef CONFIG_APM
> #define WAIT_READY      (5*HZ)          /* 5sec - some laptops are very slow */
> #else
> #define WAIT_READY      (3*HZ/100)      /* 30msec - should be instantaneous */
> #endif /* CONFIG_APM */
> #define WAIT_PIDENTIFY  (10*HZ) /* 10sec  - should be less than 3ms (?), if all ATAPI CD is closed at boot */
> #define WAIT_WORSTCASE  (30*HZ) /* 30sec  - worst case when spinning up */
> #define WAIT_CMD        (10*HZ) /* 10sec  - maximum wait for an IRQ to happen */
> #define WAIT_MIN_SLEEP  (2*HZ/100)      /* 20msec - minimum sleep time */

May I make a coding-style suggestion (which is ugly on one hand, neat
on the other):

#define mSec   *Hz/1000     /* Convert millisecs to jiffies */
#define Sec    *Hz          /* Convert secs to jiffies */


#define WAIT_DRQ        (50 mSec)   /* spec allows up to 20ms */
#ifdef CONFIG_APM
#define WAIT_READY      ( 5 Sec)    /* some laptops are very slow */
#else
#define WAIT_READY      (30 mSec)   /* should be instantaneous */
#endif /* CONFIG_APM */
#define WAIT_PIDENTIFY  (10 Sec)    /* should be less than 3ms (?), if all ATAPI CD is closed at boot */
#define WAIT_WORSTCASE  (30 Sec)    /* worst case when spinning up */
#define WAIT_CMD        (10 Sec)    /* maximum wait for an IRQ to happen */
#define WAIT_MIN_SLEEP  (20 mSec)   /* minimum sleep time */


I think that this is more readable than the above original. 

Also note that the numbers are not really repeated in the comments. If
someone changes the numbers, but not the comments, it may confuse
someone quite some time before he/she notices that the number that
is used is not the same as the one in the comment. 


				Roger. 

-- 
** R.E.Wolff@BitWizard.nl ** http://www.BitWizard.nl/ ** +31-15-2137555 **
*-- BitWizard writes Linux device drivers for any device you may have! --*
* There are old pilots, and there are bold pilots. 
* There are also old, bald pilots.