Re: 2.4.3-ac{6,7} LVM hang

[Jens Axboe <axboe@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 684 bytes --]

On Mon, Apr 16 2001, Rik van Riel wrote:
> Hi,
> 
> 2.4.3-ac4 seems to work great on my test box (UP K6-2 with SCSI
> disk), but 2.4.3-ac6 and 2.4.3-ac7 hang pretty hard when I try
> to access any of the logical volumes on my test box.
> 
> The following changelog entry in Linus' changelog suggests me
> whom to bother:   ;)
>  - Jens Axboe: LVM and loop fixes

Heh :-). I'd categorize the lvm fixes as "obviously right", haven't
checked why they seem to break for some people. Maybe the minor indexing
of LVM is broken, in which case attached patch should make it go again
(and the LVM crew needs to look into that). Also fixes a slight error in
the IO error path.

-- 
Jens Axboe


[-- Attachment #2: lvm-eout-2 --]
[-- Type: text/plain, Size: 499 bytes --]

--- /opt/kernel/linux-2.4.4-pre3/drivers/md/lvm.c	Sun Apr 15 16:24:13 2001
+++ drivers/md/lvm.c	Mon Apr 16 22:40:28 2001
@@ -1476,7 +1476,7 @@
  */
 static int lvm_map(struct buffer_head *bh, int rw)
 {
-	int minor = MINOR(bh->b_rdev);
+	int minor = MINOR(bh->b_dev);
 	int ret = 0;
 	ulong index;
 	ulong pe_start;
@@ -1675,8 +1675,11 @@
 			       struct buffer_head *bh)
 {
 	int ret = lvm_map(bh, rw);
-	if (ret < 0)
+
+	if (ret < 0) {
+		ret = 0;
 		buffer_IO_error(bh);
+	}
 	return ret;
 }