From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Alexander Viro <viro@math.psu.edu>,
Linux Kernel <linux-kernel@vger.kernel.org>,
autofs@linux.kernel.org
Subject: Re: Fix for SMP deadlock in autofs4
Date: Sat, 21 Apr 2001 00:02:56 -0700 [thread overview]
Message-ID: <20010421000256.A14074@goop.org> (raw)
In-Reply-To: <20010420184613.B12962@goop.org> <Pine.LNX.4.31.0104202253010.15553-100000@penguin.transmeta.com>
In-Reply-To: <Pine.LNX.4.31.0104202253010.15553-100000@penguin.transmeta.com>; from torvalds@transmeta.com on Fri, Apr 20, 2001 at 10:59:43PM -0700
[-- Attachment #1: Type: text/plain, Size: 757 bytes --]
On Fri, Apr 20, 2001 at 10:59:43PM -0700, Linus Torvalds wrote:
> It's untested, but looks fairly obvious. It removes the increment, and
> changes autofs4_expire() to properly bump the count of the returned dentry
> (and callers will dput() it when done). This may be unnecessarily careful,
> but it's the RightThing(tm) to do.
I suppose so. It is pretty paranoid, because of autofs4's extra reference it
can't (shouldn't) ever drop to zero until the filesystem allows it to drop to
zero. In other words, if it helps, it's hiding another bug. But you're right,
if this were a general routine, it should definitely return with an elevated
count.
> Jeremy, would you mind verifying that this WorksForYou(tm)?
Looks fine to me. I'll give it a spin.
J
[-- Attachment #2: Type: application/pgp-signature, Size: 240 bytes --]
prev parent reply other threads:[~2001-04-21 7:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-04-20 8:49 Fix for SMP deadlock in autofs4 Jeremy Fitzhardinge
2001-04-20 9:00 ` Alexander Viro
2001-04-20 9:11 ` Jeremy Fitzhardinge
2001-04-20 19:01 ` Linus Torvalds
2001-04-20 19:53 ` Alexander Viro
2001-04-21 1:46 ` Jeremy Fitzhardinge
2001-04-21 5:59 ` Linus Torvalds
2001-04-21 6:21 ` Alexander Viro
2001-04-21 7:04 ` Jeremy Fitzhardinge
2001-04-21 7:02 ` Jeremy Fitzhardinge [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010421000256.A14074@goop.org \
--to=jeremy@goop.org \
--cc=autofs@linux.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox