rwsem.o listed twice as export-objs

rwsem.o listed twice as export-objs

[Ingo Oeser]

Hi David,

please remove rwsem.o from the list of exported objects, if it is
not used.

Regards

Ingo Oeser

patch is as follows

--- lib/Makefile.orig   Fri Apr 20 21:51:12 2001
+++ lib/Makefile        Fri Apr 20 21:51:19 2001
@@ -8,7 +8,7 @@

 L_TARGET := lib.a

-export-objs := cmdline.o rwsem.o
+export-objs := cmdline.o

 obj-y := errno.o ctype.o string.o vsprintf.o brlock.o cmdline.o bust_spinlocks.o

-- 
10.+11.03.2001 - 3. Chemnitzer LinuxTag <http://www.tu-chemnitz.de/linux/tag>
         <<<<<<<<<<<<     been there and had much fun   >>>>>>>>>>>>

Re: rwsem.o listed twice as export-objs

[Christoph Hellwig]

In article <20010420215330.N682@nightmaster.csn.tu-chemnitz.de> you wrote:
> Hi David,
>
> please remove rwsem.o from the list of exported objects, if it is
> not used.

No!  The whole point of 'export-objs' is to _always_ list the objects there
to make the makefiles smaller and cleaner.

	Christoph

-- 
Of course it doesn't work. We've performed a software upgrade.

Re: rwsem.o listed twice as export-objs

[Ingo Oeser]

On Sat, Apr 21, 2001 at 06:06:34PM +0200, Christoph Hellwig wrote:
> In article <20010420215330.N682@nightmaster.csn.tu-chemnitz.de> you wrote:
> > please remove rwsem.o from the list of exported objects, if it is
> > not used.
> 
> No!  The whole point of 'export-objs' is to _always_ list the objects there
> to make the makefiles smaller and cleaner.

Ok, so this patch is better?

--- linux/lib/Makefile.orig       Sat Apr 21 20:15:00 2001
+++ linux/lib/Makefile    Sat Apr 21 20:14:37 2001
@@ -8,12 +8,11 @@

 L_TARGET := lib.a

 export-objs := cmdline.o rwsem.o

 obj-y := errno.o ctype.o string.o vsprintf.o brlock.o cmdline.o bust_spinlocks.o

 ifneq ($(CONFIG_RWSEM_GENERIC_SPINLOCK)$(CONFIG_RWSEM_XCHGADD_ALGORITHM),nn)
-export-objs += rwsem.o
 obj-y += rwsem.o
 endif



Because any of the solutions should be applied, because rwsem.o
is listed twice currently, which gives a warning at compile time.

Regards

Ingo Oeser
-- 
10.+11.03.2001 - 3. Chemnitzer LinuxTag <http://www.tu-chemnitz.de/linux/tag>
         <<<<<<<<<<<<     been there and had much fun   >>>>>>>>>>>>

Re: rwsem.o listed twice as export-objs

[Christoph Hellwig]

On Sat, Apr 21, 2001 at 08:18:15PM +0200, Ingo Oeser wrote:
> On Sat, Apr 21, 2001 at 06:06:34PM +0200, Christoph Hellwig wrote:
> > In article <20010420215330.N682@nightmaster.csn.tu-chemnitz.de> you wrote:
> > > please remove rwsem.o from the list of exported objects, if it is
> > > not used.
> > 
> > No!  The whole point of 'export-objs' is to _always_ list the objects there
> > to make the makefiles smaller and cleaner.
> 
> Ok, so this patch is better?

Yes.

	Christoph

-- 
Of course it doesn't work. We've performed a software upgrade.