public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@suse.cz>
To: viro@math.psu.edu, kernel list <linux-kernel@vger.kernel.org>
Cc: torvalds@transmeta.com
Subject: [patch] linux likes to kill bad inodes
Date: Sun, 22 Apr 2001 14:10:42 +0200	[thread overview]
Message-ID: <20010422141042.A1354@bug.ucw.cz> (raw)

Hi!

I had a temporary disk failure (played with acpi too much). What
happened was that disk was not able to do anything for five minutes
or so. When disk recovered, linux happily overwrote all inodes it
could not read while disk was down with zeros -> massive disk
corruption.

Solution is not to write bad inodes back to disk.

[Thanx to Jan Kara]							    
								Pavel

--- clean/fs/inode.c	Wed Apr  4 23:58:04 2001
+++ linux/fs/inode.c	Sun Apr 22 14:04:46 2001
@@ -179,7 +179,7 @@
 
 static inline void write_inode(struct inode *inode, int sync)
 {
-	if (inode->i_sb && inode->i_sb->s_op && inode->i_sb->s_op->write_inode)
+	if (inode->i_sb && inode->i_sb->s_op && inode->i_sb->s_op->write_inode && !is_bad_inode(inode))
 		inode->i_sb->s_op->write_inode(inode, sync);
 }
 
-- 
I'm pavel@ucw.cz. "In my country we have almost anarchy and I don't care."
Panos Katsaloulis describing me w.r.t. patents at discuss@linmodems.org

             reply	other threads:[~2001-04-25 12:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-04-22 12:10 Pavel Machek [this message]
2001-04-25 13:29 ` [patch] linux likes to kill bad inodes Chris Mason
2001-04-25 20:01   ` Pavel Machek
2001-04-25 20:28     ` Chris Mason
2001-04-26  9:28       ` Pavel Machek
2001-04-26  9:33       ` Jan Kara
2001-04-26 22:28       ` Pavel Machek
2001-04-27 14:36         ` Chris Mason
2001-04-27 22:07         ` Andreas Dilger
2001-04-27 22:14           ` Linus Torvalds
2001-04-30 22:28 ` Alan Cox
2001-04-30 22:33   ` David S. Miller
2001-04-30 23:22   ` Linus Torvalds
     [not found] <no.id>
2001-04-27 23:30 ` Andreas Dilger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010422141042.A1354@bug.ucw.cz \
    --to=pavel@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    --cc=viro@math.psu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox