Re: hundreds of mount --bind mountpoints?

Richard Gooch
2001-04-23T23:16:36Z

Alexander Viro writes:
>
>
> On Mon, 23 Apr 2001, Richard Gooch wrote:
>
> > - keep a separate VFSinode and FSinode slab cache
>
> Yup.
>
> > - allocate an enlarged VFSinode that contains the FSinode at the end,
> > with the generic pointer in the VFSinode part pointing to FSinode
> > part.
>
> Please, don't. It would help with bloat only if you allocated these
> beasts separately for each fs and then you end up with _many_ allocators
> that can generate pointer to struct inode.
>
> "One type - one allocator" is a good rule - violating it turns into
> major PITA couple of years down the road 9 times out of 10.

Agreed. The better option is the separate VFSinode and FSinode caches.
The enlarged inode scheme is also ugly, like the unions. It's just
less bloated :-)

Regards,

Richard....
Permanent: rgooch@atnf.csiro.au
Current: rgooch@ras.ucalgary.ca