public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Steven Walter <srwalter@yahoo.com>
To: linux-kernel@vger.kernel.org
Subject: serial driver not properly detecting modem
Date: Mon, 23 Apr 2001 22:38:48 -0500	[thread overview]
Message-ID: <20010423223847.A3945@hapablap.dyn.dhs.org> (raw)

It would seem that I have a modem (hardware based, not winmodem) of
PCI_CLASS_COMMUNICATION_OTHER.  This, unfortunately, prevents it from
being automagically detected by the serial driver, which only looks for
devices of PCI_CLASS_COMMUNICATION_SERIAL.

I've fixed this here merely by adding an entry to the PCI table of
serial.c for PCI_CLASS_COMMUNICATION_OTHER.  Is this the best way to fix
this?  Is there some reason that this shouldn't be done in general?  If
not, I'd like to see it fix in the kernel proper.

It should be noted that the modem is listed in serial.c's pci_boards,
perhaps it would be best for the serial driver to list PCI_ID_ANY for a
class, and only use pci_boards to further identify serial ports?  Or
would this be too inefficient to correct for a few misguided hardware
makers?

Thanks
-- 
-Steven
In a time of universal deceit, telling the truth is a revolutionary act.
			-- George Orwell

             reply	other threads:[~2001-04-24  3:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-04-24  3:38 Steven Walter [this message]
2001-04-24 11:04 ` serial driver not properly detecting modem Jeff Garzik
2001-04-24 13:38 ` Alan Cox
2001-04-24 13:46   ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010423223847.A3945@hapablap.dyn.dhs.org \
    --to=srwalter@yahoo.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox