From: Andres Salomon <dilinger@mp3revolution.net>
To: Marcus Meissner <Marcus.Meissner@caldera.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: PATCH: trident , pci_enable_device moved
Date: Wed, 25 Apr 2001 10:49:49 -0400 [thread overview]
Message-ID: <20010425104949.A31649@mp3revolution.net> (raw)
In-Reply-To: <20010425090438.A12672@caldera.de> <20010425130624.A3216@caldera.de>
In-Reply-To: <20010425130624.A3216@caldera.de>; from Marcus.Meissner@caldera.de on Wed, Apr 25, 2001 at 01:06:24PM +0200
Just a warning; I was informed by Alan that doing this for video
drivers was unnecessary, since video devices were already enabled
during bootup.
On Wed, Apr 25, 2001 at 01:06:24PM +0200, Marcus Meissner wrote:
>
> On Wed, Apr 25, 2001 at 09:04:38AM +0200, Marcus Meissner wrote:
> > Hi Alan, linux-kernel,
> >
> > This moves pci_enable_device() in trident.c before any PCI resource access.
> > Everything else appears to be ok in regards to 2.4 PCI API and return values.
> >
> > Ciao, Marcus
>
> Argh, actually the return value of pci_enable_device*() should be returned.
>
> Ciao, Marcus
>
--
"... being a Linux user is sort of like living in a house inhabited
by a large family of carpenters and architects. Every morning when
you wake up, the house is a little different. Maybe there is a new
turret, or some walls have moved. Or perhaps someone has temporarily
removed the floor under your bed." - Unix for Dummies, 2nd Edition
-- found in the .sig of Rob Riggs, rriggs@tesser.com
next prev parent reply other threads:[~2001-04-25 14:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-04-25 7:04 PATCH: trident , pci_enable_device moved Marcus Meissner
2001-04-25 11:06 ` Marcus Meissner
2001-04-25 14:49 ` Andres Salomon [this message]
2001-04-25 15:04 ` Jeff Garzik
2001-04-25 15:24 ` Andres Salomon
2001-04-25 15:35 ` Jeff Garzik
2001-04-27 9:33 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010425104949.A31649@mp3revolution.net \
--to=dilinger@mp3revolution.net \
--cc=Marcus.Meissner@caldera.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox