Architecture-specific include files

Architecture-specific include files

[Matthew Wilcox]

Something which came up in one of the hallway discussions at the
kernelsummit was that a lot of the architecture maintainers would find
it more convenient if the arch-specific header files were moved from
include/asm-$ARCH to arch/$ARCH/include.  Since we use a symlink _anyway_,
no global changes to include statements are necessary, we'd merely need
to change Makefile from

symlinks:
        rm -f include/asm
        ( cd include ; ln -sf asm-$(ARCH) asm)

to

symlinks:
        rm -f include/asm
        ( cd include ; ln -sf ../arch/$(ARCH)/include asm)

Would anyone have a problem with this change?  It'll make for a hell
of a big patch from Linus, but it really will simplify the lives of the
architecture maintainers.

-- 
Revolutions do not require corporate support.

Re: Architecture-specific include files

[Jeff Dike]

matthew@wil.cx said:
> Would anyone have a problem with this change? 

UML already has a arch/um/include for private headers that the rest of the 
kernel is not allowed to see.

It would mean moving it, which is not a big deal.

				Jeff

Re: Architecture-specific include files

[Jes Sorensen]

>>>>> "Matthew" == Matthew Wilcox <matthew@wil.cx> writes:

Matthew> Something which came up in one of the hallway discussions at
Matthew> the kernelsummit was that a lot of the architecture
Matthew> maintainers would find it more convenient if the
Matthew> arch-specific header files were moved from include/asm-$ARCH
Matthew> to arch/$ARCH/include.  Since we use a symlink _anyway_, no
Matthew> global changes to include statements are necessary, we'd
Matthew> merely need to change Makefile from

[snip]

Matthew> Would anyone have a problem with this change?  It'll make for
Matthew> a hell of a big patch from Linus, but it really will simplify
Matthew> the lives of the architecture maintainers.

I don't see what it saves, except for the fact you just have to run
diff -urN once instead of twice when you want to send Linus a large
diff. Or am I missing something?

Jes

Re: Architecture-specific include files

[Pavel Machek]

Hi!

> Matthew> Something which came up in one of the hallway discussions at
> Matthew> the kernelsummit was that a lot of the architecture
> Matthew> maintainers would find it more convenient if the
> Matthew> arch-specific header files were moved from include/asm-
> Matthew> to arch//include.  Since we use a symlink _anyway_, no
> Matthew> global changes to include statements are necessary, we'd
> Matthew> merely need to change Makefile from
> 
> [snip]
> 
> Matthew> Would anyone have a problem with this change?  It'll make for
> Matthew> a hell of a big patch from Linus, but it really will simplify
> Matthew> the lives of the architecture maintainers.
> 
> I don't see what it saves, except for the fact you just have to run
> diff -urN once instead of twice when you want to send Linus a large
> diff. Or am I missing something?

Saving one diff urN is nice, plus you can distribute your architecture
as tar file more easily, plus it is easier to put just your arch in cvs.

I like it.
								Pavel
-- 
Philips Velo 1: 1"x4"x8", 300gram, 60, 12MB, 40bogomips, linux, mutt,
details at http://atrey.karlin.mff.cuni.cz/~pavel/velo/index.html.