From: Pavel Machek <pavel@suse.cz>
To: "H. Peter Anvin" <hpa@transmeta.com>
Cc: Linus Torvalds <torvalds@transmeta.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Andries Brouwer <Andries.Brouwer@cwi.nl>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: iso9660 endianness cleanup patch
Date: Tue, 1 May 2001 20:21:40 +0000 [thread overview]
Message-ID: <20010501202139.B32@(none)> (raw)
In-Reply-To: <Pine.LNX.4.21.0104302312430.861-100000@penguin.transmeta.com> <3AEE553B.B38B00E@transmeta.com>
In-Reply-To: <3AEE553B.B38B00E@transmeta.com>; from hpa@transmeta.com on Mon, Apr 30, 2001 at 11:18:35PM -0700
Hi!
> > > The attached patch fixes both. It is against 2.4.4, but from the looks
> > > of it it should patch against -ac as well.
> >
> > Btw, please use "static inline" instead of "extern inline", as gcc may
> > decide not to inline the latter at all, leading to confusing link-time
> > errors. (Gcc may also decide not to inline "static inline", but then gcc
> > will output the actual body of the function out-of-line if it gets used,
> > so you don't get the link-time failure).
> >
> > Right now only certain broken versions of gcc will actually show this
> > behaviour, I think, but it's at least in theory going to be an issue.
> >
>
> I guess I personally prefer an error over completely broken behaviour,
> but feel free to change it.
It should ot break anything. gcc decides its bad to inline it, so it
does not inline it. Small code growth at worst. Compiler has right to
make your code bigger or slower, if it decides to do so.
--
Philips Velo 1: 1"x4"x8", 300gram, 60, 12MB, 40bogomips, linux, mutt,
details at http://atrey.karlin.mff.cuni.cz/~pavel/velo/index.html.
next prev parent reply other threads:[~2001-05-03 19:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-01 5:30 iso9660 endianness cleanup patch H. Peter Anvin
2001-05-01 6:14 ` Linus Torvalds
2001-05-01 6:18 ` H. Peter Anvin
2001-05-01 20:21 ` Pavel Machek [this message]
2001-05-04 1:51 ` Albert D. Cahalan
2001-05-04 4:59 ` Mike Galbraith
2001-05-01 6:37 ` Albert D. Cahalan
2001-05-01 9:52 ` Tim Riker
2001-05-02 8:52 ` Martin Dalecki
2001-05-02 16:03 ` H. Peter Anvin
2001-05-03 21:59 ` Pavel Machek
-- strict thread matches above, loose matches on Subject: below --
2001-05-01 14:40 Andrzej Krzysztofowicz
2001-05-01 18:16 ` H. Peter Anvin
2001-05-01 18:43 ` H. Peter Anvin
2001-05-01 20:44 ` Alan Cox
2001-05-01 20:59 ` Linus Torvalds
2001-05-01 21:06 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20010501202139.B32@(none)' \
--to=pavel@suse.cz \
--cc=Andries.Brouwer@cwi.nl \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=hpa@transmeta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox