Re: [Patch] sis_main.c

[David Weinehall <tao@acc.umu.se>]

On Fri, May 04, 2001 at 07:58:59AM -0700, Christopher Kanaan wrote:
> Hello, 
> I am a working with Dawson Englers meta compilation group at Stanford. 
> Here is a patch for sis_main.c  Basically the patch checks to see 
> if kmalloc returns null.  This patch applies to kernel version 2.4.4

Great, but why not follow Documentation/CodingStyle, and the example set
by the rest of the file?!

Instead of:

> --- /usr/src/linux/drivers/video/sis/sis_main.c Fri Feb  9 11:30:23 2001
> +++ ./sis_main.c        Fri May  4 07:34:47 2001
> @@ -1030,6 +1030,11 @@
>         if (heap.pohFreeList == NULL) {
>                 poha = kmalloc(OH_ALLOC_SIZE, GFP_KERNEL);
>  
> +               if(!poha)
> +                 {
> +                   return(NULL);
> +                 }
> +
>                 poha->pohaNext = heap.pohaChain;
>                 heap.pohaChain = poha;

Something like this:

        if (heap.pohFreeList == NULL) {
                poha = kmalloc(OH_ALLOC_SIZE, GFP_KERNEL);
 
+               if (!poha) {
+               	return(NULL);
+               }
+
                poha->pohaNext = heap.pohaChain;
                heap.pohaChain = poha;



/David Weinehall
  _                                                                 _
 // David Weinehall <tao@acc.umu.se> /> Northern lights wander      \\
//  Project MCA Linux hacker        //  Dance across the winter sky //
\>  http://www.acc.umu.se/~tao/    </   Full colour fire           </