public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: Pavel Roskin <proski@gnu.org>
Cc: Andrzej Krzysztofowicz <ankry@green.mif.pg.gda.pl>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Linus Torvalds <torvalds@transmeta.com>,
	kernel list <linux-kernel@vger.kernel.org>
Subject: Re: 2.4.4-ac4 - oops on unload "cdrom" module
Date: Sat, 5 May 2001 00:21:33 +0200	[thread overview]
Message-ID: <20010505002133.A23814@suse.de> (raw)
In-Reply-To: <200105042110.XAA20705@green.mif.pg.gda.pl> <Pine.LNX.4.33.0105041748360.872-100000@fonzie.nine.com>
In-Reply-To: <Pine.LNX.4.33.0105041748360.872-100000@fonzie.nine.com>; from proski@gnu.org on Fri, May 04, 2001 at 06:02:11PM -0400

On Fri, May 04 2001, Pavel Roskin wrote:
> > The following patch fixes unloading of cdrom module when no cdrom driver
> > loaded (2.4.5-pre, 2.4.4-ac):
> 
> It works for me. Thank you! You have even managed to find out that I had
> my CD-ROM disconnected :-)
> 
> By the way, shouldn't we register sysctl, /proc/sys/dev/cdrom/ and
> /dev/cdrom/ always when the cdrom driver is loaded/initialized, not when a
> cdrom unit is found?
> 
> I don't know what's the official "policy" is, but wouldn't it be logical
> to have some control over the drivers that handle no devices in the
> moment?

We should, the -ac tree has the first cut of the cdrom updates and they
didn't have the linking right. The right init sequence fixes the issue
as well, not just initing after the first cdrom driver registers.

-- 
Jens Axboe


  reply	other threads:[~2001-05-04 22:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-05-04 21:10 2.4.4-ac4 - oops on unload "cdrom" module Andrzej Krzysztofowicz
2001-05-04 22:02 ` Pavel Roskin
2001-05-04 22:21   ` Jens Axboe [this message]
2001-05-04 22:19 ` Jens Axboe
  -- strict thread matches above, loose matches on Subject: below --
2001-05-04 16:23 Pavel Roskin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010505002133.A23814@suse.de \
    --to=axboe@suse.de \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=ankry@green.mif.pg.gda.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=proski@gnu.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox