PCMCIA IDE flash problem found

PCMCIA IDE flash problem found

[Pavel Machek]

Hi!

2.4.[123] changed name of ide-cs module, which means your pcmcia setup
breaks... This is how to undo the damage. Works for me, do *not* apply
into anything official.

								Pavel

--- clean/drivers/ide/ide-cs.c	Sun Apr  1 00:23:29 2001
+++ linux/drivers/ide/ide-cs.c	Tue May  8 14:06:09 2001
@@ -95,7 +96,7 @@
 static int ide_event(event_t event, int priority,
 		     event_callback_args_t *args);
 
-static dev_info_t dev_info = "ide-cs";
+static dev_info_t dev_info = "ide_cs";
 
 static dev_link_t *ide_attach(void);
 static void ide_detach(dev_link_t *);
@@ -388,9 +389,12 @@
 	MOD_DEC_USE_COUNT;
     }
 
+#if 0
     request_region(link->io.BasePort1, link->io.NumPorts1,"ide-cs");
     if (link->io.NumPorts2)
 	request_region(link->io.BasePort2, link->io.NumPorts2,"ide-cs");
+#endif
+    printk("Should call request_region\n");
     
     info->ndev = 0;
     link->dev = NULL;

-- 
I'm pavel@ucw.cz. "In my country we have almost anarchy and I don't care."
Panos Katsaloulis describing me w.r.t. patents at discuss@linmodems.org

RE: PCMCIA IDE flash problem found

[Khachaturov, Vassilii]

Why did not you take care of the request_region() call and just disabled it?
The ports will be considered free by the system, and another device might 
grab them later on!

Vassilii

-----Original Message-----
From: Pavel Machek [mailto:pavel@suse.cz]
Sent: Tuesday, May 08, 2001 8:14 AM
To: kernel list
Subject: PCMCIA IDE flash problem found


Hi!

2.4.[123] changed name of ide-cs module, which means your pcmcia setup
breaks... This is how to undo the damage. Works for me, do *not* apply
into anything official.

								Pavel

--- clean/drivers/ide/ide-cs.c	Sun Apr  1 00:23:29 2001
+++ linux/drivers/ide/ide-cs.c	Tue May  8 14:06:09 2001
@@ -95,7 +96,7 @@
 static int ide_event(event_t event, int priority,
 		     event_callback_args_t *args);
 
-static dev_info_t dev_info = "ide-cs";
+static dev_info_t dev_info = "ide_cs";
 
 static dev_link_t *ide_attach(void);
 static void ide_detach(dev_link_t *);
@@ -388,9 +389,12 @@
 	MOD_DEC_USE_COUNT;
     }
 
+#if 0
     request_region(link->io.BasePort1, link->io.NumPorts1,"ide-cs");
     if (link->io.NumPorts2)
 	request_region(link->io.BasePort2, link->io.NumPorts2,"ide-cs");
+#endif
+    printk("Should call request_region\n");
     
     info->ndev = 0;
     link->dev = NULL;

Re: PCMCIA IDE flash problem found

[Pavel Machek]

> Why did not you take care of the request_region() call and just disabled it?
> The ports will be considered free by the system, and another device might 
> grab them later on!

Because it was one of changes between 2.4.0 and 2.4.4. Ignore that.

								Pavel
> 
> Vassilii
> 
> -----Original Message-----
> From: Pavel Machek [mailto:pavel@suse.cz]
> Sent: Tuesday, May 08, 2001 8:14 AM
> To: kernel list
> Subject: PCMCIA IDE flash problem found
> 
> 
> Hi!
> 
> 2.4.[123] changed name of ide-cs module, which means your pcmcia setup
> breaks... This is how to undo the damage. Works for me, do *not* apply
> into anything official.
> 
> 								Pavel
> 
> --- clean/drivers/ide/ide-cs.c	Sun Apr  1 00:23:29 2001
> +++ linux/drivers/ide/ide-cs.c	Tue May  8 14:06:09 2001
> @@ -95,7 +96,7 @@
>  static int ide_event(event_t event, int priority,
>  		     event_callback_args_t *args);
>  
> -static dev_info_t dev_info = "ide-cs";
> +static dev_info_t dev_info = "ide_cs";
>  
>  static dev_link_t *ide_attach(void);
>  static void ide_detach(dev_link_t *);
> @@ -388,9 +389,12 @@
>  	MOD_DEC_USE_COUNT;
>      }
>  
> +#if 0
>      request_region(link->io.BasePort1, link->io.NumPorts1,"ide-cs");
>      if (link->io.NumPorts2)
>  	request_region(link->io.BasePort2, link->io.NumPorts2,"ide-cs");
> +#endif
> +    printk("Should call request_region\n");
>      
>      info->ndev = 0;
>      link->dev = NULL;

-- 
The best software in life is free (not shareware)!		Pavel
GCM d? s-: !g p?:+ au- a--@ w+ v- C++@ UL+++ L++ N++ E++ W--- M- Y- R+