public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* Bad udelay usage in drivers/net/aironet4500_card.c
@ 2001-05-15 21:37 H . J . Lu
  2001-05-19  7:45 ` Paul Gortmaker
  0 siblings, 1 reply; 3+ messages in thread
From: H . J . Lu @ 2001-05-15 21:37 UTC (permalink / raw)
  To: linux kernel

In 2.4.4, drivers/net/aironet4500_card.c has

# grep udelay linux/drivers/net/aironet4500_card.c
                udelay(1000);
        udelay(100);
                udelay(10);
        udelay(100000);
        udelay(200000);
        udelay(250000);
        udelay(10000);
        udelay(10000);
        udelay(1000);
        udelay(1000);
        udelay(10000);

But on ia32, you cannot use more than 20000 for udelay (). You will get
undefined symbol, __bad_udelay.


H.J.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Bad udelay usage in drivers/net/aironet4500_card.c
       [not found] <20010516123312.978.qmail@web4303.mail.yahoo.com>
@ 2001-05-16 15:52 ` H . J . Lu
  0 siblings, 0 replies; 3+ messages in thread
From: H . J . Lu @ 2001-05-16 15:52 UTC (permalink / raw)
  To: Jalaja Devi; +Cc: linux kernel

On Wed, May 16, 2001 at 05:33:12AM -0700, Jalaja Devi wrote:
> Hi!
> Could you please tell me how you fixed the udelay
> problem. cuz, I am encountering the same problem in my
> driver.
> 

I am not a kernel expert. You should ask it on the kernel mailing
list.

> Thanks for your time,
> Jalaja
> 
> 
> In 2.4.4, drivers/net/aironet4500_card.c has 
> 
> 
> # grep udelay linux/drivers/net/aironet4500_card.c 
>                 udelay(1000); 
>         udelay(100); 
>                 udelay(10); 
>         udelay(100000); 
>         udelay(200000); 
>         udelay(250000); 
>         udelay(10000); 
>         udelay(10000); 
>         udelay(1000); 
>         udelay(1000); 
>         udelay(10000); 
> 
> 
> But on ia32, you cannot use more than 20000 for udelay
> (). You will get 
> undefined symbol, __bad_udelay. 
> 
> 
> 
> 
> __________________________________________________
> Do You Yahoo!?
> Yahoo! Auctions - buy the things you want at great prices
> http://auctions.yahoo.com/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Bad udelay usage in drivers/net/aironet4500_card.c
  2001-05-15 21:37 H . J . Lu
@ 2001-05-19  7:45 ` Paul Gortmaker
  0 siblings, 0 replies; 3+ messages in thread
From: Paul Gortmaker @ 2001-05-19  7:45 UTC (permalink / raw)
  To: H . J . Lu; +Cc: linux kernel

H . J . Lu wrote:
> 
> In 2.4.4, drivers/net/aironet4500_card.c has

>         udelay(100000);
>         udelay(200000);
>         udelay(250000);

> 
> But on ia32, you cannot use more than 20000 for udelay (). You will get
> undefined symbol, __bad_udelay.

mv driver.c driver.c~
sed 's/udelay\( *\)(\([1-9][0-9]*\)000)/mdelay\1(\2)/' <driver.c~>driver.c

...keeps foo(...) or foo (...) as per original author's taste.
            ^           ^
Paul.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2001-05-19  7:54 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20010516123312.978.qmail@web4303.mail.yahoo.com>
2001-05-16 15:52 ` Bad udelay usage in drivers/net/aironet4500_card.c H . J . Lu
2001-05-15 21:37 H . J . Lu
2001-05-19  7:45 ` Paul Gortmaker

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox