Re: 8139too on 2.2.19 doesn't close file descriptors

Andrew Morton
2001-05-18T10:57:31Z

Santiago Garcia Mantinan wrote:
>
> Hi!
>
> I was tracking down a problem with Debian installation freezing when doing
> the ifconfig of the 8139too driver on 2.2.19 kernel, and found that this was
> caused by 8139too for 2.2.19 not closing it's file descriptors.
>
> The original code by Jeff for the 2.4 series is ok, and searching for the
> cause of the problem I have found a difference in the way rtl8139_thread
> exits on both versions:
>
> 2.2 version:
> up (&tp->thr_exited);
> return 0;
>
> 2.4 version:
> up_and_exit (&tp->thr_exited, 0);
>
> I think the problem must be there, not doing the do_exit on the 2.2 version,
> but I may be wrong, can anybody look this up?

No, that's OK.

In 2.2, daemonize() does *not* do exit_files(). In 2.4
it does. I wonder why?

Try putting an

exit_files(current);

at the start of rtl8139_thread()