From: Francois Romieu <romieu@cogenit.fr>
To: Marcus Meissner <Marcus.Meissner@caldera.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: PATCH: maestro ported to 2.4 PCI API
Date: Mon, 21 May 2001 19:05:45 +0200 [thread overview]
Message-ID: <20010521190545.A3522@se1.cogenit.fr> (raw)
In-Reply-To: <20010521173707.A10692@caldera.de>
In-Reply-To: <20010521173707.A10692@caldera.de>; from Marcus.Meissner@caldera.de on Mon, May 21, 2001 at 05:37:07PM +0200
Marcus Meissner <Marcus.Meissner@caldera.de> ecrit :
[...]
> if( request_region(iobase, 256, card_names[card_type]) == NULL )
> {
> printk(KERN_WARNING "maestro: can't allocate 256 bytes I/O at 0x%4.4x\n", iobase);
> - return 0;
> - }
> -
> - /* this was tripping up some machines */
> - if(pcidev->irq == 0) {
> - printk(KERN_WARNING "maestro: pci subsystem reports irq 0, this might not be correct.\n");
> + return -EBUSY;
> }
>
> /* just to be sure */
> @@ -3406,7 +3429,7 @@
> if(card == NULL)
> {
> printk(KERN_WARNING "maestro: out of memory\n");
> - return 0;
> + return -ENOMEM;
request_region is unbalanced in this return path.
--
Ueimor
next prev parent reply other threads:[~2001-05-21 17:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-21 15:37 PATCH: maestro ported to 2.4 PCI API Marcus Meissner
2001-05-21 17:05 ` Francois Romieu [this message]
2001-05-21 21:23 ` Marcus Meissner
2001-05-21 18:45 ` Zach Brown
2001-05-21 18:46 ` Alan Cox
2001-05-21 20:31 ` Zach Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010521190545.A3522@se1.cogenit.fr \
--to=romieu@cogenit.fr \
--cc=Marcus.Meissner@caldera.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox