From: Guest section DW <dwguest@win.tue.nl>
To: Oliver Xymoron <oxymoron@waste.org>,
Anton Altaparmakov <aia21@cam.ac.uk>
Cc: Alexander Viro <viro@math.psu.edu>,
Linus Torvalds <torvalds@transmeta.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] struct char_device
Date: Tue, 22 May 2001 21:22:38 +0200 [thread overview]
Message-ID: <20010522212238.A11203@win.tue.nl> (raw)
In-Reply-To: <5.1.0.14.2.20010522153915.00ac1630@pop.cus.cam.ac.uk> <Pine.LNX.4.30.0105221104070.19818-100000@waste.org>
In-Reply-To: <Pine.LNX.4.30.0105221104070.19818-100000@waste.org>; from Oliver Xymoron on Tue, May 22, 2001 at 11:08:16AM -0500
On Tue, May 22, 2001 at 11:08:16AM -0500, Oliver Xymoron wrote:
> > >+ struct list_head hash;
> > Why not name consistently with the struct block_device?
> > struct list_head cd_hash;
> Because foo_ is a throwback to the days when C compilers had a single
> namespace for all structure elements, not a readability aid. If you need
> foo_ to know what type of structure you're futzing with, you need to name
> your variables better.
One often has to go through all occurrences of a variable or
field of a struct. That is much easier with cd_hash and cd_dev
than with hash and dev.
No, it is a good habit, these prefixes, even though it is no longer
necessary because of the C compiler.
next prev parent reply other threads:[~2001-05-22 19:22 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.GSO.4.21.0105221007460.15685-100000@weyl.math.psu.edu >
2001-05-22 15:26 ` [PATCH] struct char_device Anton Altaparmakov
2001-05-22 16:08 ` Oliver Xymoron
2001-05-22 16:12 ` Alexander Viro
2001-05-22 17:30 ` Oliver Xymoron
2001-05-22 17:41 ` Alexander Viro
2001-05-22 19:22 ` Guest section DW [this message]
2001-05-22 19:25 ` Alexander Viro
2001-05-22 19:38 ` Oliver Xymoron
2001-05-23 20:01 Andries.Brouwer
-- strict thread matches above, loose matches on Subject: below --
2001-05-23 18:28 Andries.Brouwer
2001-05-23 18:42 ` Alexander Viro
2001-05-23 15:24 Wayne.Brown
2001-05-23 13:34 Andries.Brouwer
2001-05-23 17:54 ` Alexander Viro
2001-05-24 10:35 ` Stephen C. Tweedie
2001-05-23 12:29 Andries.Brouwer
2001-05-23 12:30 ` Alan Cox
2001-05-23 13:26 ` Helge Hafting
2001-05-23 11:57 Andries.Brouwer
2001-05-23 12:13 ` Alan Cox
2001-05-23 6:47 Andries.Brouwer
2001-05-23 0:28 Andries.Brouwer
2001-05-23 0:38 ` Alexander Viro
2001-05-23 0:22 Andries.Brouwer
2001-05-23 0:29 ` Martin Dalecki
2001-05-23 0:20 Andries.Brouwer
2001-05-23 2:43 ` Linus Torvalds
2001-05-23 0:01 Andries.Brouwer
2001-05-22 23:33 Andries.Brouwer
2001-05-23 0:03 ` Alexander Viro
2001-05-22 22:17 Andries.Brouwer
2001-05-22 22:34 ` Martin Dalecki
2001-05-22 22:47 ` Martin Dalecki
2001-05-23 0:02 ` Jeff Garzik
2001-05-23 0:14 ` Jens Axboe
2001-05-23 2:40 ` Linus Torvalds
2001-05-23 12:35 ` Martin Dalecki
2001-05-22 21:35 Andries.Brouwer
2001-05-22 22:00 ` Martin Dalecki
2001-05-22 20:54 Andries.Brouwer
2001-05-22 21:17 ` Martin Dalecki
2001-05-22 22:37 ` Linus Torvalds
2001-05-22 23:51 ` Alexander Viro
2001-05-23 0:06 ` Jeff Garzik
2001-05-23 0:14 ` Jens Axboe
2001-05-23 2:37 ` Linus Torvalds
2001-05-23 3:04 ` Jeff Garzik
2001-05-23 3:21 ` Jeff Garzik
2001-05-23 9:05 ` Alan Cox
2001-05-23 2:35 ` Linus Torvalds
2001-05-22 19:52 Andries.Brouwer
2001-05-22 20:10 ` Alexander Viro
[not found] <Pine.LNX.4.10.10105221050080.8984-100000@coffee.psychology.mcmaster.ca>
2001-05-22 14:59 ` Tommy Hallgren
2001-05-22 14:40 Tommy Hallgren
2001-05-22 14:18 Alexander Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010522212238.A11203@win.tue.nl \
--to=dwguest@win.tue.nl \
--cc=aia21@cam.ac.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=oxymoron@waste.org \
--cc=torvalds@transmeta.com \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox