From: Lars Marowsky-Bree <lmb@suse.de>
To: Tobias Ringstrom <tori@unhappy.mine.nu>
Cc: kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers/net/others
Date: Thu, 24 May 2001 10:51:37 +0200 [thread overview]
Message-ID: <20010524105137.A574@marowsky-bree.de> (raw)
In-Reply-To: <200105240102.DAA27178@green.mif.pg.gda.pl> <Pine.LNX.4.33.0105241035230.10914-100000@boris.prodako.se>
In-Reply-To: <Pine.LNX.4.33.0105241035230.10914-100000@boris.prodako.se>; from "Tobias Ringstrom" on 2001-05-24T10:45:25
On 2001-05-24T10:45:25,
Tobias Ringstrom <tori@unhappy.mine.nu> said:
> > if (!printed_version++)
> > - printk(version);
> > + printk("%s", version);
> >
> > DMFE_DBUG(0, "dmfe_init_one()", 0);
> >
>
> Could you please explain the purpose of this change? To me it looks less
> efficient in both performance and memory usage.
Potentially, version might include stuff which is interpreted by printk if not
quoted - the above fixes this. Paranoia always helps ;-)
Sincerely,
Lars Marowsky-Brée <lmb@suse.de>
--
Perfection is our goal, excellence will be tolerated. -- J. Yahl
next prev parent reply other threads:[~2001-05-24 8:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-24 1:02 [PATCH] drivers/net/others Andrzej Krzysztofowicz
2001-05-24 3:43 ` Jeff Garzik
2001-05-24 8:45 ` Tobias Ringstrom
2001-05-24 8:51 ` Lars Marowsky-Bree [this message]
2001-05-24 12:01 ` Andrzej Krzysztofowicz
2001-05-24 14:30 ` Alan Cox
2001-05-24 16:00 ` Jonathan Lundell
2001-05-24 18:22 ` Rasmus Andersen
2001-05-25 9:08 ` Paul Gortmaker
2001-05-25 11:38 ` Andrzej Krzysztofowicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010524105137.A574@marowsky-bree.de \
--to=lmb@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tori@unhappy.mine.nu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox