From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Thu, 24 May 2001 04:52:03 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Thu, 24 May 2001 04:51:53 -0400 Received: from gate.in-addr.de ([212.8.193.158]:3856 "HELO mx.in-addr.de") by vger.kernel.org with SMTP id ; Thu, 24 May 2001 04:51:47 -0400 Date: Thu, 24 May 2001 10:51:37 +0200 From: Lars Marowsky-Bree To: Tobias Ringstrom Cc: kernel list Subject: Re: [PATCH] drivers/net/others Message-ID: <20010524105137.A574@marowsky-bree.de> In-Reply-To: <200105240102.DAA27178@green.mif.pg.gda.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.2.3i In-Reply-To: ; from "Tobias Ringstrom" on 2001-05-24T10:45:25 X-Ctuhulu: HASTUR Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On 2001-05-24T10:45:25, Tobias Ringstrom said: > > if (!printed_version++) > > - printk(version); > > + printk("%s", version); > > > > DMFE_DBUG(0, "dmfe_init_one()", 0); > > > > Could you please explain the purpose of this change? To me it looks less > efficient in both performance and memory usage. Potentially, version might include stuff which is interpreted by printk if not quoted - the above fixes this. Paranoia always helps ;-) Sincerely, Lars Marowsky-Brée -- Perfection is our goal, excellence will be tolerated. -- J. Yahl