Re: [PATCH] drivers/net/others

Rasmus Andersen
2001-05-24T18:22:37Z

On Thu, May 24, 2001 at 09:00:20AM -0700, Jonathan Lundell wrote:
[...]
>
> Fine. But:
>
> At 3:02 AM +0200 2001-05-24, Andrzej Krzysztofowicz wrote:
> >- printk(version);
> >+#ifdef MODULE
> >+ printk("s", version);
> > printed_version = 1;
> >+#endif /* MODULE */
>
> ...is playing it just a little too safe, wouldn't you say?

With the above snippet of code being remailed a couple of times
somebody surely noticed before me that the printk should have
"%s" as format string, not "s". But then again somebody might
not so there you are.
--
Rasmus(rasmus@jaquet.dk)

"A statesman... is a dead politician. Lord knows, we need more statesmen."
-- Bloom County