Re: [PATCH] drivers/net/others

Tobias Ringstrom
2001-05-24T08:46:33Z

Andrzej,

Thanks for your impressive clean-up patch. I have a couple of comments
regarding your clean-up of the dmfe.c driver.

On Thu, 24 May 2001, Andrzej Krzysztofowicz wrote:

> @@ -395,7 +395,7 @@
> u32 dev_rev, pci_pmr;
>
> if (!printed_version++)
> - printk(version);
> + printk("%s", version);
>
> DMFE_DBUG(0, "dmfe_init_one()", 0);
>

Could you please explain the purpose of this change? To me it looks less
efficient in both performance and memory usage.

> @@ -2024,8 +2027,10 @@
> {
> int rc;
>
> - printk(version);
> +#ifdef MODULE
> + printk("s", version);
> printed_version = 1;
> +#endif /* MODULE */
>
> DMFE_DBUG(0, "init_module() ", debug);
>

Whoups... And why did you add the ifdef, btw?

/Tobias