Re: [PATCH] drivers/net/others

Lars Marowsky-Bree
2001-05-24T08:52:03Z

On 2001-05-24T10:45:25,
Tobias Ringstrom <tori@unhappy.mine.nu> said:

> > if (!printed_version++)
> > - printk(version);
> > + printk("%s", version);
> >
> > DMFE_DBUG(0, "dmfe_init_one()", 0);
> >
>
> Could you please explain the purpose of this change? To me it looks less
> efficient in both performance and memory usage.

Potentially, version might include stuff which is interpreted by printk if not
quoted - the above fixes this. Paranoia always helps ;-)

Sincerely,
Lars Marowsky-Brée <lmb@suse.de>

--
Perfection is our goal, excellence will be tolerated. -- J. Yahl