Re: [PATCH] bulkmem.c - null ptr fixes for 2.4.4

Re: [PATCH] bulkmem.c - null ptr fixes for 2.4.4

[Arnaldo Carvalho de Melo]

Em Thu, May 24, 2001 at 03:26:20PM +0100, Alan Cox escreveu:
> > kernel code. This patch fixes numerous unchecked pointers in the PCMCIA 
> > bulkmem driver. 
> 
> Since when has two been numerous - also I dont thin the fix is right - you need
> to undo what has already been done

and anyway, 2.4.4-ac15 already has the checks, it just doesnt deallocates
what's have already been inserted in the list in setup_regions, the memory
doesn't seem to get lost, but I think its better deallocate whats been
done if it fails halfway in setup_regions.

- Arnaldo

Re: [PATCH] bulkmem.c - null ptr fixes for 2.4.4

[Praveen Srinivasan]

Do we need to free the linked list in setup_regions? Would it be easier to 
try and preallocate the structures beforehand, and then fill them with the 
loop? Btw, we didn't find anything wrong with the first part of the patch.

Praveen Srinivasan and Frederick Akalin

Alan Cox wrote:

>> kernel code. This patch fixes numerous unchecked pointers in the PCMCIA
>> bulkmem driver.
> 
> Since when has two been numerous - also I dont thin the fix is right - you
> need to undo what has already been done
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

[PATCH] bulkmem.c - null ptr fixes for 2.4.4

[Praveen Srinivasan]

Hi,
Using the Stanford checker, we searched for null-pointer bugs in the linux 
kernel code. This patch fixes numerous unchecked pointers in the PCMCIA 
bulkmem driver. 

Praveen Srinivasan and Frederick Akalin

--- ../linux/./drivers/pcmcia/bulkmem.c	Tue Mar  6 19:28:32 2001
+++ ./drivers/pcmcia/bulkmem.c	Mon May  7 21:53:49 2001
@@ -229,6 +229,10 @@
 	else {
 	    erase->State = 1;
 	    busy = kmalloc(sizeof(erase_busy_t), GFP_KERNEL);
+
+	    if(busy == NULL) {
+	      return;
+	    }
 	    busy->erase = erase;
 	    busy->client = handle;
 	    init_timer(&busy->timeout);
@@ -360,6 +364,10 @@
 	if ((device.dev[i].type != CISTPL_DTYPE_NULL) &&
 	    (device.dev[i].size != 0)) {
 	    r = kmalloc(sizeof(*r), GFP_KERNEL);
+	    if(r == NULL) {
+	      return;
+	    }
+
 	    r->region_magic = REGION_MAGIC;
 	    r->state = 0;
 	    r->dev_info[0] = '\0';

Re: [PATCH] bulkmem.c - null ptr fixes for 2.4.4

[Alan Cox]

> kernel code. This patch fixes numerous unchecked pointers in the PCMCIA 
> bulkmem driver. 

Since when has two been numerous - also I dont thin the fix is right - you need
to undo what has already been done