From: Russell King <rmk@arm.linux.org.uk>
To: Rodrigo Ventura <yoda@isr.ist.utl.pt>
Cc: linux-kernel@vger.kernel.org
Subject: Re: patch to put IDE drives in sleep-mode after an halt
Date: Thu, 24 May 2001 12:11:52 +0100 [thread overview]
Message-ID: <20010524121152.A11086@flint.arm.linux.org.uk> (raw)
In-Reply-To: <lx4rubc8kq.fsf@pixie.isr.ist.utl.pt>
In-Reply-To: <lx4rubc8kq.fsf@pixie.isr.ist.utl.pt>; from yoda@isr.ist.utl.pt on Thu, May 24, 2001 at 12:03:49PM +0100
On Thu, May 24, 2001 at 12:03:49PM +0100, Rodrigo Ventura wrote:
> I am submitting a patch to kernel/sys.c that walks through all
> IDE drives (#ifdef CONFIG_BLK_DEV_IDE, of course), and issues a
> "sleep" command (as code in hdparam) to each one of them right before
> the kernel halts. Here goes the diff:
I'm not going to comment on the idea, just the implementation. Eww.
First point is that this has no business being in kernel/sys.c - it
belongs in the ide layer, not the generic kernel.
Secondly, you have this wonderous reboot notifier list which you can
arbitarily register functions with throughout the kernel, and they
will get called prior to halt/reboot. You should be using this, via
the register_reboot_notifier() hooks.
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
next prev parent reply other threads:[~2001-05-24 11:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-24 11:03 patch to put IDE drives in sleep-mode after an halt Rodrigo Ventura
2001-05-24 11:11 ` Russell King [this message]
2001-05-24 13:20 ` Erik Mouw
2001-05-24 13:52 ` Rodrigo Ventura
-- strict thread matches above, loose matches on Subject: below --
2001-05-24 12:29 peter k.
2001-05-24 12:46 ` Adrian V. Bono
2001-05-24 12:59 ` peter k.
2001-05-24 13:18 ` Erik Mouw
2001-05-24 15:16 Petr Vandrovec
2001-05-24 17:38 ` idalton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010524121152.A11086@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=yoda@isr.ist.utl.pt \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox