From: Rasmus Andersen <rasmus@jaquet.dk>
To: Jonathan Lundell <jlundell@pobox.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/net/others
Date: Thu, 24 May 2001 20:22:15 +0200 [thread overview]
Message-ID: <20010524202215.A845@jaquet.dk> (raw)
In-Reply-To: <E152w81-00053C-00@the-village.bc.nu> <p05100304b732e04cf9aa@[207.213.214.37]>
In-Reply-To: <p05100304b732e04cf9aa@[207.213.214.37]>; from jlundell@pobox.com on Thu, May 24, 2001 at 09:00:20AM -0700
On Thu, May 24, 2001 at 09:00:20AM -0700, Jonathan Lundell wrote:
[...]
>
> Fine. But:
>
> At 3:02 AM +0200 2001-05-24, Andrzej Krzysztofowicz wrote:
> >- printk(version);
> >+#ifdef MODULE
> >+ printk("s", version);
> > printed_version = 1;
> >+#endif /* MODULE */
>
> ...is playing it just a little too safe, wouldn't you say?
With the above snippet of code being remailed a couple of times
somebody surely noticed before me that the printk should have
"%s" as format string, not "s". But then again somebody might
not so there you are.
--
Rasmus(rasmus@jaquet.dk)
"A statesman... is a dead politician. Lord knows, we need more statesmen."
-- Bloom County
next prev parent reply other threads:[~2001-05-24 18:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-24 1:02 [PATCH] drivers/net/others Andrzej Krzysztofowicz
2001-05-24 3:43 ` Jeff Garzik
2001-05-24 8:45 ` Tobias Ringstrom
2001-05-24 8:51 ` Lars Marowsky-Bree
2001-05-24 12:01 ` Andrzej Krzysztofowicz
2001-05-24 14:30 ` Alan Cox
2001-05-24 16:00 ` Jonathan Lundell
2001-05-24 18:22 ` Rasmus Andersen [this message]
2001-05-25 9:08 ` Paul Gortmaker
2001-05-25 11:38 ` Andrzej Krzysztofowicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010524202215.A845@jaquet.dk \
--to=rasmus@jaquet.dk \
--cc=jlundell@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox