From: Rasmus Andersen <rasmus@jaquet.dk>
To: axboe@suse.de
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] check kmalloc return in ide-cd.c (244-ac16)
Date: Fri, 25 May 2001 21:34:22 +0200 [thread overview]
Message-ID: <20010525213422.B851@jaquet.dk> (raw)
Hi.
This patch adds a check for the return value from kmalloc in
ide_cdrom_open. Applies against ac16.
--- linux-244-ac16-clean/drivers/ide/ide-cd.c Fri May 25 21:11:08 2001
+++ linux-244-ac16/drivers/ide/ide-cd.c Fri May 25 21:30:20 2001
@@ -2869,12 +2869,12 @@
int ide_cdrom_open (struct inode *ip, struct file *fp, ide_drive_t *drive)
{
struct cdrom_info *info = drive->driver_data;
- int rc;
+ int rc = -ENOMEM;
MOD_INC_USE_COUNT;
if (info->buffer == NULL)
info->buffer = (char *) kmalloc(SECTOR_BUFFER_SIZE, GFP_KERNEL);
- if ((rc = cdrom_fops.open(ip, fp))) {
+ if ((info->buffer == NULL) || (rc = cdrom_fops.open(ip, fp))) {
drive->usage--;
MOD_DEC_USE_COUNT;
}
--
Regards,
Rasmus(rasmus@jaquet.dk)
The police are not here to create disorder. They're here to preserve
disorder." -Former Chicago mayor Daley during the infamous 1968 Democratic
Party convention
next reply other threads:[~2001-05-25 19:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-25 19:34 Rasmus Andersen [this message]
2001-05-25 21:02 ` [PATCH] check kmalloc return in ide-cd.c (244-ac16) Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010525213422.B851@jaquet.dk \
--to=rasmus@jaquet.dk \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox