public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrea Arcangeli <andrea@suse.de>
To: "David S. Miller" <davem@redhat.com>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org,
	Linus Torvalds <torvalds@transmeta.com>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Subject: Re: [patch] severe softirq handling performance bug, fix, 2.4.5
Date: Sun, 27 May 2001 19:18:22 +0200	[thread overview]
Message-ID: <20010527191822.J676@athlon.random> (raw)
In-Reply-To: <Pine.LNX.4.33.0105261920030.3336-200000@localhost.localdomain> <15120.16986.610478.279574@pizda.ninka.net>
In-Reply-To: <15120.16986.610478.279574@pizda.ninka.net>; from davem@redhat.com on Sat, May 26, 2001 at 04:55:06PM -0700

On Sat, May 26, 2001 at 04:55:06PM -0700, David S. Miller wrote:
> And looking at the x86 code, I don't even understand how your fixes
> can make a difference, what about the do_softirq() call in
> arch/i386/kernel/irq.c:do_IRQ()???  That should be taking care of all
> these "error cases" right?

Yes, except when a softirq is marked running again under do_sofitrq (it
is mostly an issue when the machine is otherwise idle that means we
will waste cpu if we don't run the sofitrq immediatly, this problem was
noticed by Manfred last month, but that is just a special case of the
generic case of a softirq marked running again under do_softirq), and
all those cases are supposed to be taken care by ksoftirqd.

Andrea

  parent reply	other threads:[~2001-05-27 17:18 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-05-26 17:59 [patch] severe softirq handling performance bug, fix, 2.4.5 Ingo Molnar
2001-05-26 19:33 ` [patch] softirq-2.4.5-A1 Ingo Molnar
2001-05-27 17:12   ` Andrea Arcangeli
2001-05-27 19:08     ` Ingo Molnar
2001-05-27 20:05       ` Andrea Arcangeli
2001-05-28  1:17         ` Horst von Brand
2001-05-26 23:55 ` [patch] severe softirq handling performance bug, fix, 2.4.5 David S. Miller
2001-05-27  3:28   ` Albert D. Cahalan
2001-05-27 17:18   ` Andrea Arcangeli [this message]
2001-05-27 19:00   ` [patch] softirq-2.4.5-B0 Ingo Molnar
2001-05-27 19:15     ` David S. Miller
2001-05-27 19:19       ` Ingo Molnar
2001-05-27 17:07 ` [patch] severe softirq handling performance bug, fix, 2.4.5 Andrea Arcangeli
2001-05-27 17:17   ` David S. Miller
2001-05-27 17:56     ` Andrea Arcangeli
2001-05-27 19:05       ` Ingo Molnar
2001-05-27 19:55         ` Andrea Arcangeli
2001-05-27 21:00           ` Ingo Molnar
2001-05-28 19:26             ` kuznet
2001-05-27 19:09       ` David S. Miller
2001-05-27 20:24         ` Andrea Arcangeli
2001-06-10 10:40 ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010527191822.J676@athlon.random \
    --to=andrea@suse.de \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=davem@redhat.com \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox