From: Andrzej Krzysztofowicz <ankry@green.mif.pg.gda.pl>
To: alan@lxorguk.ukuu.org.uk (Alan Cox)
Cc: alan@lxorguk.ukuu.org.uk (Alan Cox),
jgarzik@mandrakesoft.com (Jeff Garzik),
Philip.Blundell@pobox.com,
linux-kernel@vger.kernel.org (kernel list)
Subject: Re: [PATCH] net #6
Date: Wed, 30 May 2001 12:35:17 +0200 (CEST) [thread overview]
Message-ID: <200105301035.MAA06191@green.mif.pg.gda.pl> (raw)
In-Reply-To: <E1550vA-0005Xe-00@the-village.bc.nu> from "Alan Cox" at May 30, 2001 09:01:36 AM
>
> > The following patch removes unnecessary #ifdefs from eexpress.c
>
> They are neccessary
Yes, you are right.
I was suggested by improper part of spinlock.h ...
Forget this patch.
> > @@ -643,9 +631,7 @@
> > eexp_hw_tx_pio(dev,data,length);
> > }
> > dev_kfree_skb(buf);
> > -#ifdef CONFIG_SMP
> > spin_unlock_irqrestore(&lp->lock, flags);
> > -#endif
> > enable_irq(dev->irq);
> > return 0;
>
> They are done this way to get good non SMP performance. Your changes would
> ruin that.
--
=======================================================================
Andrzej M. Krzysztofowicz ankry@mif.pg.gda.pl
tel. (0-58) 347 14 61
Wydz.Fizyki Technicznej i Matematyki Stosowanej Politechniki Gdanskiej
next prev parent reply other threads:[~2001-05-30 10:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-30 0:44 [PATCH] net #6 Andrzej Krzysztofowicz
2001-05-30 8:01 ` Alan Cox
2001-05-30 10:35 ` Andrzej Krzysztofowicz [this message]
2001-05-30 22:24 ` Pavel Machek
2001-05-31 21:35 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200105301035.MAA06191@green.mif.pg.gda.pl \
--to=ankry@green.mif.pg.gda.pl \
--cc=Philip.Blundell@pobox.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jgarzik@mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox