Re: [PATCH] net #3

[Andrzej Krzysztofowicz <ankry@pg.gda.pl>]

"Paul Gortmaker wrote:"
> Andrzej Krzysztofowicz wrote:
> > 
> > The following patch fixes some ISA PnP #ifdefs (enable modular,
> > disable when non-available) for 3c509 and smc-ultra.
> 
> > -#ifdef CONFIG_ISAPNP
> > +#if defined(CONFIG_ISAPNP) || (defined(CONFIG_ISAPNP_MODULE) && defined(MODULE))
> 
> Hrrm.  AFAICT the token CONFIG_ISAPNP_MODULE will never be defined.  :-)

If IS defined by config subsystem when
  "$CONFIG_ISAPNP" = "m"

Just mark config option and test it.

$ grep ISAPNP include/linux/autoconf.h
#undef  CONFIG_ISAPNP
#define CONFIG_ISAPNP_MODULE 1
#undef  CONFIG_BLK_DEV_ISAPNP

;)

> Regardless, we can just toss the #ifdefs altogether.  They aren't strictly
> required as appropriate stubs exist in linux/isapnp.h and that is what 
> they are there for. (I'd recommend this for 2.5, not 2.4 though.)
> 
> Granted, the CONFIG_ISAPNP buys you a slight reduction in driver
> size (even over the stubs) which somewhat seemed worthwhile in the
> past. But most of it is __init anyway, and for 2.5 I'd argue that the
> readability and lack of ifdefs outweighs the slight size change.

When __init for modules will be implemented ?

Andrzej
-- 
=======================================================================
  Andrzej M. Krzysztofowicz               ankry@mif.pg.gda.pl
  phone (48)(58) 347 14 61
Faculty of Applied Phys. & Math.,   Technical University of Gdansk