public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.org>
To: Steve Whitehouse <Steve@ChyGwyn.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Zerocopy NBD
Date: Wed, 30 May 2001 18:40:47 +0200	[thread overview]
Message-ID: <20010530184047.J17136@suse.de> (raw)
In-Reply-To: <200105301639.RAA21383@gw.chygwyn.com>
In-Reply-To: <200105301639.RAA21383@gw.chygwyn.com>; from steve@gw.chygwyn.com on Wed, May 30, 2001 at 05:39:58PM +0100

On Wed, May 30 2001, Steve Whitehouse wrote:
> +	if (PageHighMem(page))
> +		offset = (int)bh->b_data;
> +	else
> +		offset = (int)bh->b_data - (int)page_address(page);

Side note:

	offset = bh_offset(bh);

will handle this nicely for you. No need for (nasty) casting and
checking for highmem pages.

-- 
Jens Axboe


      parent reply	other threads:[~2001-05-30 16:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-05-30 16:39 Zerocopy NBD Steve Whitehouse
2001-05-30 15:08 ` Marcelo Tosatti
2001-05-30 17:15   ` Steve Whitehouse
2001-05-30 16:02     ` Marcelo Tosatti
2001-05-30 16:40 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010530184047.J17136@suse.de \
    --to=axboe@kernel.org \
    --cc=Steve@ChyGwyn.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox